fix(kmod): embedded_function_name for checkpatch#1252
Merged
Conversation
Signed-off-by: Koichi Imai <koichi.imai.2@tier4.jp>
Koichi98
added
the
need-patch-update
Signed-off-by: Koichi Imai <koichi.imai.2@tier4.jp>
Signed-off-by: Koichi Imai <koichi.imai.2@tier4.jp>
8 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Linux kernel checkpatch.pl EMBEDDED_FUNCTION_NAME warnings in the kernel module by switching log messages to __func__, and adds a helper script to run checkpatch locally.
Changes:
- Replace embedded function-name strings in
agnocast_kmodlog messages with__func__. - Add
scripts/run_checkpatch.bashfor running checkpatch against kernel-module sources. - Minor related message/comment touch-ups while addressing checkpatch warnings.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| scripts/run_checkpatch.bash | Adds a convenience script to run checkpatch.pl against kernel module sources. |
| agnocast_kmod/agnocast_ioctl.c | Updates many log messages to include __func__ to satisfy checkpatch. |
| agnocast_kmod/agnocast_internal.c | Updates log messages to use __func__. |
| agnocast_kmod/agnocast_init.c | Updates a log message to use __func__. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Koichi Imai <koichi.imai.2@tier4.jp>
…t into fix/embedded_function_name
Signed-off-by: Koichi Imai <koichi.imai.2@tier4.jp>
kobayu858
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix
EMBEDDED_FUNCTION_NAMEwarning for checkpatch.Also added
scripts/run_checkpatch.bashto so that everyone can run checkpatch easily.Related links
PR: validate checkpatch as required in github workflows #1251
Issue: fixing checkpatch warnings/errors #1253
Description for
EMBEDDED_FUNCTION_NAMEHow was this PR tested?
bash scripts/test/e2e_test_1to1.bash(required)bash scripts/test/e2e_test_2to2.bash(required)bash scripts/test/run_requires_kernel_module_tests.bash(required)Notes for reviewers
Version Update Label (Required)
Please add exactly one of the following labels to this PR:
need-major-update: User API breaking changesneed-minor-update: Internal API breaking changes (heaphook/kmod/agnocastlib compatibility)need-patch-update: Bug fixes and other changesImportant notes:
need-major-updateorneed-minor-update, please include this in the PR title as well.fix(foo)[needs major version update]: barorfeat(baz)[needs minor version update]: quxrun-build-testlabel. The PR can only be merged after the build tests pass.See CONTRIBUTING.md for detailed versioning rules.