feat(argocd-image-updater): Add missing config values, webhook support, and controller flags#3800
Conversation
0dfbb69 to
c9ab6e0
Compare
| - kind: fixed | ||
| description: Remove command override in deployment to allow Dockerfile ENTRYPOINT with tini init process to prevent zombie processes | ||
| - kind: added | ||
| description: Add missing config values (log.format, interval, max_concurrent_apps, max_concurrent_reconciles, argocd.namespace) |
There was a problem hiding this comment.
Put this PR into draft. Re add the PR checklist that you allowed your LLM to delete and follow it please.
|
Thanks for flagging the GenAI policy — I've read through it. I used Claude Code as a coding assistant, but the changes are based on my own review of the argocd-image-updater controller source where I identified gaps between upstream CLI flags/ConfigMap keys and what I've put the PR in draft for now — happy to mark it ready for review whenever you're comfortable with it. |
69a2d82 to
bef1c1b
Compare
…t, and controller flags - Add discoverable config values: log.format, interval, max_concurrent_apps, max_concurrent_reconciles, argocd.namespace - Add webhook configuration: webhook.enable, webhook.port, webhook.ratelimit-allowed - Wire Aliyun ACR and CloudEvents webhook secret env vars in deployment - Add metricsSecure and enableHTTP2 as first-class controller args - Wire health-probe-bind-address to containerPorts.health value Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Ilia <ilia.lazebnik@gmail.com>
…ptional These flags only apply to the new controller-runtime based `run` command and should not be rendered unless explicitly set by the user. Default to empty string so the flags are omitted entirely when not configured. Signed-off-by: Ilia Lazebnik <ilia.lazebnik@gmail.com> Signed-off-by: Ilia <ilia.lazebnik@placer.ai>
bef1c1b to
dc2f18a
Compare
Signed-off-by: Ilia Lazebnik <ilia.lazebnik@gmail.com> Signed-off-by: Ilia <ilia.lazebnik@placer.ai>
Signed-off-by: Ilia Lazebnik <ilia.lazebnik@gmail.com> Signed-off-by: Ilia <ilia.lazebnik@placer.ai>
Due to the following reasons, shall we follow as argo-cd's way instead of adding all configs?
WDYT? 😄 @mkilchhofer @jmeridth @tico24 |
Yep, that was our / my idea when I upgraded the AIU to 1.0 (PR was created by Renovate): |
|
I can rebase this but what are the next steps? similar PR for rollouts was merged. i can close this or make other changes if needed |
I'd like to drop the changes in the |
Per maintainer feedback (mkilchhofer), drop the new config keys (log.format, interval, max_concurrent_apps, max_concurrent_reconciles, argocd.namespace, webhook.enable, webhook.port, webhook.ratelimit-allowed) from values.yaml. Keep template wiring for new webhook secrets, the metricsSecure/enableHTTP2 controller flags, and health-probe-bind-address. Signed-off-by: Ilia Lazebnik <ilia.lazebnik@gmail.com>
|
Done — dropped all |
Checklist:
Summary
This PR adds (per maintainer review, the
config:value additions were dropped — only template wiring remains):ALIYUN_ACR_WEBHOOK_SECRETandCLOUDEVENTS_WEBHOOK_SECRET(new in v1.1.0 for ECR CloudEvents support) are now wired in the deployment templatemetricsSecureandenableHTTP2are now first-class values instead of requiringextraArgs--health-probe-bind-addressis now wired tocontainerPorts.healthinstead of being hardcodedBoolean flags default to
nil, so the CLI args are omitted entirely unless explicitly set — fully backwards compatible.Test plan
helm templatewith defaults renders correctly (no extra args)helm templatewithmetricsSecure=falseandenableHTTP2=truerenders correct CLI args