fix(argocd-image-updater): make metricsSecure and enableHTTP2 fully optional

These flags only apply to the new controller-runtime based `run` command
and should not be rendered unless explicitly set by the user. Default to
empty string so the flags are omitted entirely when not configured.

Signed-off-by: Ilia Lazebnik <[email protected]>
Signed-off-by: Ilia <[email protected]>

Author: DrFaust92

charts/argocd-image-updater/README.md

@@ -112,7 +112,7 @@ The `config.registries` value can be used exactly as it looks in the documentati
 | createClusterRoles | bool | `true` | Create cluster roles for cluster-wide installation. |
 | dualStack.ipFamilies | list | `[]` | IP families that should be supported and the order in which they should be applied to ClusterIP as well. Can be IPv4 and/or IPv6. |
 | dualStack.ipFamilyPolicy | string | `""` | IP family policy to configure dual-stack see [Configure dual-stack](https://kubernetes.io/docs/concepts/services-networking/dual-stack/#services) |
-| enableHTTP2 | bool | `false` | Enable HTTP/2 for the metrics and webhook servers |
+| enableHTTP2 | string | `""` | Enable HTTP/2 for the metrics and webhook servers. Upstream default is `false`. Only applies to the new `run` command (controller-runtime based). Leave empty to omit the flag entirely. @type -- bool |
 | extraArgs | list | `[]` | Extra arguments for argocd-image-updater not defined in `config.argocd`. If a flag contains both key and value, they need to be split to a new entry. |
 | extraEnv | list | `[]` | Extra environment variables for argocd-image-updater. |
 | extraEnvFrom | list | `[]` | Extra envFrom to pass to argocd-image-updater |
@@ -144,7 +144,7 @@ The `config.registries` value can be used exactly as it looks in the documentati
 | metrics.serviceMonitor.namespace | string | `""` | Prometheus ServiceMonitor namespace |
 | metrics.serviceMonitor.relabelings | list | `[]` | Prometheus [RelabelConfigs] to apply to samples before scraping |
 | metrics.serviceMonitor.selector | object | `{}` | Prometheus ServiceMonitor selector |
-| metricsSecure | bool | `true` | Serve metrics endpoint securely via HTTPS (default `true`). Set to `false` to use HTTP |
+| metricsSecure | string | `""` | Serve metrics endpoint securely via HTTPS. Upstream default is `true`. Only applies to the new `run` command (controller-runtime based). Leave empty to omit the flag entirely. @type -- bool |
 | nameOverride | string | `""` | Global name (argocd-image-updater.name in _helpers.tpl) override |
 | namespaceOverride | string | `""` | Global namespace (argocd-image-updater.namespace in _helpers.tpl) override |
 | nodeSelector | object | `{}` | Kubernetes nodeSelector settings for the deployment |

charts/argocd-image-updater/templates/deployment.yaml

@@ -37,11 +37,11 @@ spec:
           args:
             - --metrics-bind-address=:{{ .Values.containerPorts.metrics }}
             - --health-probe-bind-address=:{{ .Values.containerPorts.health }}
-            {{- if not .Values.metricsSecure }}
-            - --metrics-secure=false
+            {{- if kindIs "bool" .Values.metricsSecure }}
+            - --metrics-secure={{ .Values.metricsSecure }}
             {{- end }}
-            {{- if .Values.enableHTTP2 }}
-            - --enable-http2
+            {{- if kindIs "bool" .Values.enableHTTP2 }}
+            - --enable-http2={{ .Values.enableHTTP2 }}
             {{- end }}
             - run
             {{- with .Values.extraArgs }}

charts/argocd-image-updater/values.yaml

@@ -36,11 +36,13 @@ namespaceOverride: ""
 ## If you want to use this, please set `.Values.rbac.enabled` true as well.
 createClusterRoles: true
 
-# -- Serve metrics endpoint securely via HTTPS (default `true`). Set to `false` to use HTTP
-metricsSecure: true
+# -- Serve metrics endpoint securely via HTTPS. Upstream default is `true`. Only applies to the new `run` command (controller-runtime based). Leave empty to omit the flag entirely.
+# @type -- bool
+metricsSecure: ""
 
-# -- Enable HTTP/2 for the metrics and webhook servers
-enableHTTP2: false
+# -- Enable HTTP/2 for the metrics and webhook servers. Upstream default is `false`. Only applies to the new `run` command (controller-runtime based). Leave empty to omit the flag entirely.
+# @type -- bool
+enableHTTP2: ""
 
 # -- Extra arguments for argocd-image-updater not defined in `config.argocd`.
 # If a flag contains both key and value, they need to be split to a new entry.