tauon: 7.9.0 -> 8.0.1 by jansol · Pull Request #405753 · NixOS/nixpkgs

jansol · 2025-05-10T01:40:27Z

Things done

Add a 👍 reaction to pull requests you find important.

jansol · 2025-05-12T23:09:30Z

Eventually it to work with setupHook instead of patching. Still feels kind of brittle but eh 🤷.

At least tauon seems to be happy and in a nix develop nixpkgs#tauon shell importing sdl3 and calling sdl3.SDL_CreateWindow works as expected. (with a warning about a mismatch in the minor version of libSDL3_ttf but it'll have to live with that)

marcin-serwin

Thanks, it looks better now in my opinion. Just some minor changes.

marcin-serwin · 2025-05-13T15:00:30Z

Could you add a comment above that explains the reason for this setupHook? Something like

Suggested change

setupHook = ./setup-hook.sh;

# PySDL3 downloads SDL binaries itself by default so we set env variables to make it use the ones from nixpkgs

# See https://pysdl3.readthedocs.io/en/latest/install.html#the-environment-variable-method

setupHook = ./setup-hook.sh;

marcin-serwin · 2025-05-13T15:05:58Z

Suggested change

"";

throw "Unsupported system: ${stdenv.hostPlatform.system}";

jansol · 2025-05-13T21:35:01Z

(Oh right, dynamic libraries have different suffixes on different platforms)

pbsds · 2025-05-14T13:59:41Z

+  docfile = fetchurl {
+    url = "https://github.com/Aermoss/PySDL3/releases/download/v${version}/${stdenv.hostPlatform.uname.system}-Docs.py";
+    hash = "${dochash}";
+  };


rather than fetching this generated asset, please generate it in the derivation if possible. The procedure seems to be in https://github.com/Aermoss/PySDL3/blob/main/.github/workflows/generate_docs.yml.

If we do have to fetch it, then we should set meta.sourceProvenance accordingly.

The generator attempts to first download the file from the github release so that would not really change anything. If downloading it from the github release fails, it starts scraping docs from libsdl.org which I'm also not a huge fan of (it mostly seems like a great way to get our CI machines IP blocked these days).

Ideally we'd generate the docs from our own SDL3 build. I was going to propose supporting that case to upstream but didn't manage to get nixpkgs SDL3 to generate its documentation...

sounds like a big can of worms, i'm not against fetching it in the meanwhile 👍

What shoud meta.sourceProvenance be set to in this case? binaryBytecode?

pbsds · 2025-05-14T17:23:19Z

on darwin ofborg:

OSError: dlopen(/nix/store/vywskmfkwb412cm7r6ryq1my809vis1i-python3.12-pysdl3-0.9.8b1/lib/python3.12/site-packages/sdl3/bin/libSDL3_ttf.dylib, 0x0006): Library not loaded: /opt/homebrew/opt/harfbuzz/lib/libharfbuzz.0.dylib
  Referenced from: <0C7CE85E-DE89-38C3-BCE5-6F34F347BE98> /nix/store/vywskmfkwb412cm7r6ryq1my809vis1i-python3.12-pysdl3-0.9.8b1/lib/python3.12/site-packages/sdl3/bin/libSDL3_ttf.dylib
  Reason: tried: '/opt/homebrew/opt/harfbuzz/lib/libharfbuzz.0.dylib' (no such file), '/System/Volumes/Preboot/Cryptexes/OS/opt/homebrew/opt/harfbuzz/lib/libharfbuzz.0.dylib' (no such file), '/opt/homebrew/opt/harfbuzz/lib/libharfbuzz.0.dylib' (no such file)

pbsds · 2025-05-14T17:31:28Z

On further inspection this seems to be a sdl3_ttf issue not pysdl3 issue, and i'm unable to recreate it on the darwin community builder indicating that the harfbuzz package is not guaranteed to be present on a given darwin machine

pbsds · 2025-05-14T17:56:06Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 405753

`x86_64-linux`

✅ 6 packages built:

python312Packages.pysdl3
python312Packages.pysdl3.dist
python313Packages.pysdl3
python313Packages.pysdl3.dist
tauon
tauon.dist

`aarch64-linux`

✅ 6 packages built:

python312Packages.pysdl3
python312Packages.pysdl3.dist
python313Packages.pysdl3
python313Packages.pysdl3.dist
tauon
tauon.dist

`x86_64-darwin`

✅ 4 packages built:

python312Packages.pysdl3
python312Packages.pysdl3.dist
python313Packages.pysdl3
python313Packages.pysdl3.dist

`aarch64-darwin`

✅ 4 packages built:

python312Packages.pysdl3
python312Packages.pysdl3.dist
python313Packages.pysdl3
python313Packages.pysdl3.dist

pbsds · 2025-05-14T17:58:32Z

$ results/tauon-x86_64-linux/bin/tauon
2025-05-14 19:57:26 [ INFO  ] [ __main__ ] Tauon v8.0.1
2025-05-14 19:57:26 [ INFO  ] [ __main__ ] Copyright 2015-2025 Taiko2k [email protected]

Error: Failed to write docs: [Errno 30] Read-only file system: '/nix/store/81l56jnx7p2pi7xqgizxabnils8pijbn-python3.13-pysdl3-0.9.8b1/lib/python3.13/site-packages/sdl3/__doc__.py'.
Error: Invoked an unimplemented function: 'SDL_SetHint'.
Error: Invoked an unimplemented function: 'SDL_SetHint'.
Error: Invoked an unimplemented function: 'SDL_SetHint'.
Error: Invoked an unimplemented function: 'SDL_SetHint'.
Error: Invoked an unimplemented function: 'SDL_SetHint'.
2025-05-14 19:57:27 [ INFO  ] [ __main__ ] No window state file
Error: Invoked an unimplemented function: 'SDL_Init'.
Error: Invoked an unimplemented function: 'SDL_GetError'.
Error: Invoked an unimplemented function: 'SDL_CreateWindow'.
2025-05-14 19:57:27 [ ERROR ] [ __main__ ] ERROR CREATING WINDOW! (__main__.py:332)
2025-05-14 19:57:27 [ ERROR ] [ __main__ ] Title: b'Tauon' (__main__.py:333)
2025-05-14 19:57:27 [ ERROR ] [ __main__ ] X: 536805376 (__main__.py:334)
2025-05-14 19:57:27 [ ERROR ] [ __main__ ] Y: 536805376 (__main__.py:335)
2025-05-14 19:57:27 [ ERROR ] [ __main__ ] Size 0: 1120 (__main__.py:336)
2025-05-14 19:57:27 [ ERROR ] [ __main__ ] Size 1: 600 (__main__.py:337)
2025-05-14 19:57:27 [ ERROR ] [ __main__ ] Flags: 1073750064 (__main__.py:338)
Error: Invoked an unimplemented function: 'SDL_GetError'.
2025-05-14 19:57:27 [ ERROR ] [ __main__ ] SDL Error: None (__main__.py:339)
2025-05-14 19:57:27 [WARNING] [ warnings ] sys:1: ResourceWarning: unclosed file <_io.TextIOWrapper name='/home/pbsds/.local/share/TauonMusicBox/program.pid' mode='w' encoding='UTF-8'>
 (warnings.py:112)

I think the doc fetching needs to be patched

jansol · 2025-05-14T22:00:28Z

I think the doc fetching needs to be patched

That error message is referring to a different python version than on my machine. Can you check the directory structure of the result from nix build .#python3Packages.pysdl3? There should be sdl3/__doc__.py in the relevant site-packages. If the rest of the .py files are in a different place that would explain this error and it would mean I messed up the paths in postInstall.

pbsds · 2025-05-14T22:13:54Z

Oh, i think the error was from nixpkgs-review populating the shell with multiple python versions of pysdl3 in PYTHONPATH. This is a known problem. Running it with only tauon in the shell gives me a GUI. It however print this error without crashing:

2025-05-15 00:10:24 [ ERROR ] [  t_main  ] Failed to load libXcursor.so, will try libXcursor.so.1 (t_main.py:40496)
Traceback (most recent call last):
  File "/nix/store/rdxmvih92mzdrsxxjjrcv2k1mh28w904-tauon-8.0.1/lib/python3.12/site-packages/tauon/t_modules/t_main.py", line 40494, in <module>
    xcu = ctypes.cdll.LoadLibrary("libXcursor.so")
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/kjvgj2n3yn70hmjifg6y0bk9m4rf7jba-python3-3.12.10/lib/python3.12/ctypes/__init__.py", line 460, in LoadLibrary
    return self._dlltype(name)
           ^^^^^^^^^^^^^^^^^^^
  File "/nix/store/kjvgj2n3yn70hmjifg6y0bk9m4rf7jba-python3-3.12.10/lib/python3.12/ctypes/__init__.py", line 379, in __init__
    self._handle = _dlopen(self._name, mode)
                   ^^^^^^^^^^^^^^^^^^^^^^^^^
OSError: libXcursor.so: cannot open shared object file: No such file or directory

Likely the LoadLibrary("libXcursor.so") needs to be patched or the bin/tauon entrypoint needs to add libXcursor to the library path

jansol · 2025-05-14T22:31:04Z

If that's all then the good news is that we were wrapping the main entrypoint and stuffing things into LD_LIBRARY_PATH already so adding libXcursor is a minimal change.

pbsds · 2025-05-15T09:16:29Z

TIL that fixes https://github.com/.../pull/123#issuecomment-456 will ignore the comment anchor and close the PR

pbsds · 2025-05-16T06:46:11Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 405753

`x86_64-linux`

✅ 6 packages built:

python312Packages.pysdl3
python312Packages.pysdl3.dist
python313Packages.pysdl3
python313Packages.pysdl3.dist
tauon
tauon.dist

`aarch64-linux`

✅ 6 packages built:

python312Packages.pysdl3
python312Packages.pysdl3.dist
python313Packages.pysdl3
python313Packages.pysdl3.dist
tauon
tauon.dist

`x86_64-darwin`

✅ 4 packages built:

python312Packages.pysdl3
python312Packages.pysdl3.dist
python313Packages.pysdl3
python313Packages.pysdl3.dist

`aarch64-darwin`

✅ 4 packages built:

python312Packages.pysdl3
python312Packages.pysdl3.dist
python313Packages.pysdl3
python313Packages.pysdl3.dist

github-actions Bot added the 6.topic: python Python is a high-level, general-purpose programming language. label May 10, 2025

jansol mentioned this pull request May 10, 2025

tauon: 7.9.0 -> 8.0.0 #396827

Closed

13 tasks

nix-owners Bot requested a review from natsukium May 10, 2025 01:42

jansol mentioned this pull request May 10, 2025

teams.sdl needs maintainers #405245

Closed

28 tasks

jansol force-pushed the tauon branch from e14fc45 to 40dd132 Compare May 10, 2025 01:47

github-actions Bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 10, 2025

marcin-serwin requested changes May 10, 2025

View reviewed changes

jansol force-pushed the tauon branch from 40dd132 to 3bbc4af Compare May 12, 2025 22:59

jansol force-pushed the tauon branch from 3bbc4af to 846924c Compare May 13, 2025 01:07

marcin-serwin requested changes May 13, 2025

View reviewed changes

jansol force-pushed the tauon branch from 846924c to 2b41119 Compare May 13, 2025 20:59

marcin-serwin approved these changes May 13, 2025

View reviewed changes

python3Packages.pysdl3: init at 0.9.8b1

c223fac

jansol force-pushed the tauon branch from 2b41119 to 334950d Compare May 13, 2025 21:34

pbsds reviewed May 14, 2025

View reviewed changes

pbsds mentioned this pull request May 14, 2025

sdl3-ttf: use fixDarwinDylibNames #407090

Merged

13 tasks

jansol force-pushed the tauon branch 2 times, most recently from 4d783cd to 180ffa2 Compare May 14, 2025 22:30

jansol force-pushed the tauon branch from 180ffa2 to 68649f8 Compare May 14, 2025 22:48

tauon: 7.9.0 -> 8.0.1

59041b8

jansol force-pushed the tauon branch from 68649f8 to 59041b8 Compare May 14, 2025 23:01

pbsds closed this in #407090 May 15, 2025

pbsds reopened this May 15, 2025

pbsds merged commit cb9e5af into NixOS:master May 16, 2025
36 of 37 checks passed

jansol deleted the tauon branch May 16, 2025 10:02

-  setupHook = ./setup-hook.sh;
+  # PySDL3 downloads SDL binaries itself by default so we set env variables to make it use the ones from nixpkgs
+  # See https://pysdl3.readthedocs.io/en/latest/install.html#the-environment-variable-method
+  setupHook = ./setup-hook.sh;

	"";
	throw "Unsupported system: ${stdenv.hostPlatform.system}";

Uh oh!

Conversation

jansol commented May 10, 2025

Things done

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jansol commented May 12, 2025

Uh oh!

marcin-serwin left a comment

Choose a reason for hiding this comment

Uh oh!

marcin-serwin May 13, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

marcin-serwin May 13, 2025

Choose a reason for hiding this comment

Uh oh!

jansol commented May 13, 2025

Uh oh!

pbsds May 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jansol May 14, 2025

Choose a reason for hiding this comment

Uh oh!

pbsds May 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jansol May 14, 2025

Choose a reason for hiding this comment

Uh oh!

pbsds commented May 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pbsds commented May 14, 2025

Uh oh!

pbsds commented May 14, 2025

nixpkgs-review result

x86_64-linux

aarch64-linux

x86_64-darwin

aarch64-darwin

Uh oh!

pbsds commented May 14, 2025

Uh oh!

jansol commented May 14, 2025

Uh oh!

pbsds commented May 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jansol commented May 14, 2025

Uh oh!

pbsds commented May 15, 2025

Uh oh!

pbsds commented May 16, 2025

nixpkgs-review result

x86_64-linux

aarch64-linux

x86_64-darwin

aarch64-darwin

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

pbsds May 14, 2025 •

edited

Loading

pbsds May 14, 2025 •

edited

Loading

pbsds commented May 14, 2025 •

edited

Loading

`nixpkgs-review` result

`x86_64-linux`

`aarch64-linux`

`x86_64-darwin`

`aarch64-darwin`

pbsds commented May 14, 2025 •

edited

Loading

`nixpkgs-review` result

`x86_64-linux`

`aarch64-linux`

`x86_64-darwin`

`aarch64-darwin`