Skip to content

sdl3-ttf: use fixDarwinDylibNames#407090

Merged
pbsds merged 2 commits intoNixOS:masterfrom
pbsds:fix-sdl3-ttf-1747244163
May 15, 2025
Merged

sdl3-ttf: use fixDarwinDylibNames#407090
pbsds merged 2 commits intoNixOS:masterfrom
pbsds:fix-sdl3-ttf-1747244163

Conversation

@pbsds
Copy link
Copy Markdown
Member

@pbsds pbsds commented May 14, 2025

  • sdl3-ttf: use fixDarwinDylibNames
  • sdl3-ttf: remove unused input

i hope this fixes #405753 (comment), since i can't reproduce the error nor do i know how to inspect dylibs i can't test this

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions Bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels May 14, 2025
@nix-owners nix-owners Bot requested review from Emin017 and chai-yuan May 14, 2025 18:02
Copy link
Copy Markdown
Member

@Emin017 Emin017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Emin017
Copy link
Copy Markdown
Member

Emin017 commented May 15, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 407090

Logs: https://github.com/Emin017/nixpkgs-review-gha/actions/runs/15035391142


x86_64-darwin

✅ 1 package built:
  • sdl3-ttf

aarch64-darwin

✅ 1 package built:
  • sdl3-ttf

@pbsds pbsds merged commit 6ec6cd1 into NixOS:master May 15, 2025
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants