tauon: 7.9.0 -> 8.0.0#396827
Closed
tanya1866 wants to merge 1 commit intoNixOS:masterfrom
Closed
Conversation
github-actions
Bot
added
10.rebuild-darwin: 0
Contributor
|
ddogfoodd
reviewed
Apr 7, 2025
Contributor
ddogfoodd
left a comment
ddogfoodd
left a comment
There was a problem hiding this comment.
error log still contains old version and pysdl3 not installed
error log below:
error: builder for '/nix/store/rwm6r3nilyglvr9866d475hfq8gdplqy-tauon-8.0.0.drv' failed with exit code 1;
last 25 log lines:
> adding 'tauon/theme/Sunken.ttheme'
> adding 'tauon/theme/Turbo.ttheme'
> adding 'tauon/theme/Vape.ttheme'
> adding 'tauon/theme/Wasp.ttheme'
> adding 'tauon/theme/Charmed/Charmed.tdeco'
> adding 'tauon/theme/Charmed/Charmed.ttheme'
> adding 'tauon_music_box-7.9.0.dist-info/LICENSE'
> adding 'tauon_music_box-7.9.0.dist-info/METADATA'
> adding 'tauon_music_box-7.9.0.dist-info/NOTICE'
> adding 'tauon_music_box-7.9.0.dist-info/WHEEL'
> adding 'tauon_music_box-7.9.0.dist-info/entry_points.txt'
> adding 'tauon_music_box-7.9.0.dist-info/top_level.txt'
> adding 'tauon_music_box-7.9.0.dist-info/RECORD'
> removing build/bdist.linux-x86_64/wheel
> Successfully built tauon_music_box-7.9.0-cp312-cp312-linux_x86_64.whl
> Finished creating a wheel...
> /build/source/dist /build/source
> Unpacking to: unpacked/tauon_music_box-7.9.0...OK
> Repacking wheel as ./tauon_music_box-7.9.0-cp312-cp312-linux_x86_64.whl...OK
> /build/source
> Finished executing pypaBuildPhase
> Running phase: pythonRuntimeDepsCheckHook
> Executing pythonRuntimeDepsCheck
> Checking runtime dependencies for tauon_music_box-7.9.0-cp312-cp312-linux_x86_64.whl
> - pysdl3 not installed
For full logs, run 'nix log /nix/store/rwm6r3nilyglvr9866d475hfq8gdplqy-tauon-8.0.0.drv'.
error: 1 dependencies of derivation '/nix/store/04z0ap63i6m9bhyqv3lrb85f57wwy687-review-shell.drv' failed to build
Contributor
|
Yeah pysdl3 is not an optional dependency, we're just going to have to wait until that is packaged. |
Contributor
Author
perhaps i can try adding pysdl3 |
pbsds
reviewed
Apr 18, 2025
| --replace-fail 'base_path = Path(pctl.install_directory).parent.parent / "build"' 'base_path = Path("${placeholder "out"}/${python3Packages.python.sitePackages}")' | ||
| ''; | ||
|
|
||
| dontUsePythonRuntimeDepsCheck = true; |
Member
There was a problem hiding this comment.
please add a comment about why this is here, so others know when it can be re-enabled
Contributor
|
PySDL3 turned out to be more of a mess than I thought, so I went ahead and gave this a stab myself: #405753 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated tauon: 7.9.0 -> 8.0.0
Changelog
Tauon 8.0.0 requires pysdl3 which is not currently packaged in nixpkgs, I tried adding it to pythonRemoveDeps but that doesnt seam to work
Closes #396814
Maintainer: @jansol
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.