AL-1042: Add a distinct corrector for Roman#243
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #243 +/- ##
==========================================
- Coverage 93.53% 93.51% -0.02%
==========================================
Files 11 11
Lines 2011 2021 +10
==========================================
+ Hits 1881 1890 +9
- Misses 130 131 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
braingram
left a comment
There was a problem hiding this comment.
LGTM. 2 minor comments that don't need to hold up approval.
|
I actually do wonder if it would be better to move the new class to |
If the new class is supposed to have the same purpose and functionality as that for JWST, I don't think it should be moved to |
|
Thanks for making the updates. Code LGTM. Would you run and link regression tests for jwst and roman that use this PR? |
Done |
|
Re-running regression tests for pipelines using this branch as dependency. It does not test that new correcto for |
|
Regression tests pass but CI style check is failing with numerous warnings in unrelated files possibly caused by #247. Should I revert that PR? |
Add a roman-specific corrector class with unique romantics string.