AL-1042: Use roman-specific tweakwcs corrector#2219
AL-1042: Use roman-specific tweakwcs corrector#2219mcara wants to merge 9 commits intospacetelescope:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2219 +/- ##
=======================================
Coverage 80.55% 80.55%
=======================================
Files 155 155
Lines 9338 9339 +1
=======================================
+ Hits 7522 7523 +1
Misses 1816 1816 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Although regression tests fail, it is actually just one unit test that is failing and, based on the line numbers in the traceback, it looks like unit tests (when run as part of the entire regression test) do not use install overrides and so they do not use required package versions by |
|
Last commit (only temporary, to illustrate the last point) sets dependency to spacetelescope/stcal#529 and the regression tests with this commit are: https://github.com/spacetelescope/RegressionTests/actions/runs/22793185624 |
|
Tests are going to fail until the |
|
If you want, I can make a temporary commit to make them pass (it will need to be dropped before merging) |
|
I'm okay with either a temporary commit or a link to passing regression tests. The approach you're taking here looks reasonable to me and I'm happy to move forward with it, pending your deciding which of the various options is the best. Thanks! |
mairanteodoro
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks, Mihai!
I can approve once all the tests are passing.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Co-authored-by: Brett Graham <[email protected]>
for more information, see https://pre-commit.ci
03401d0 to
15f46ca
Compare
Resolves AL-1042
This PR switches correctors used in tweakreg from a jwst corrector to a dedicated roman-specific corrector. This PR depends on spacetelescope/tweakwcs#243 and spacetelescope/stcal#529 being merged and
teakwcsversion0.9.0be released. Unit tests will not pass unless we modifypyproject.tomlto use those branches ofstcalandtweakwcs.Tasks
24Q4_B15(use the latest build if not sure)no-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see changelog readme for instructions)changes/<PR#>.breaking.rstnews fragmentdocs/pageokify_regteststo update the truth files