Skip to content

AL-1042: Use roman-specific tweakwcs corrector#2219

Open
mcara wants to merge 9 commits intospacetelescope:mainfrom
mcara:move-corrector-to-roman-pipeline
Open

AL-1042: Use roman-specific tweakwcs corrector#2219
mcara wants to merge 9 commits intospacetelescope:mainfrom
mcara:move-corrector-to-roman-pipeline

Conversation

@mcara
Copy link
Copy Markdown
Member

@mcara mcara commented Mar 6, 2026

Resolves AL-1042

This PR switches correctors used in tweakreg from a jwst corrector to a dedicated roman-specific corrector. This PR depends on spacetelescope/tweakwcs#243 and spacetelescope/stcal#529 being merged and teakwcs version 0.9.0 be released. Unit tests will not pass unless we modify pyproject.toml to use those branches of stcal and tweakwcs.

Tasks

  • request a review from someone specific, to avoid making the maintainers review every PR
  • add a build milestone, i.e. 24Q4_B15 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see changelog readme for instructions)
      • if your change breaks existing functionality, also add a changes/<PR#>.breaking.rst news fragment
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly

@mcara mcara self-assigned this Mar 6, 2026
@mcara mcara requested review from a team and mairanteodoro as code owners March 6, 2026 17:43
@github-actions github-actions Bot added the dependencies Pull requests that update a dependency file label Mar 6, 2026
@mcara
Copy link
Copy Markdown
Member Author

mcara commented Mar 6, 2026

Comment thread changes/2219.tweakreg.rst Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.55%. Comparing base (0bec7d5) to head (15f46ca).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2219   +/-   ##
=======================================
  Coverage   80.55%   80.55%           
=======================================
  Files         155      155           
  Lines        9338     9339    +1     
=======================================
+ Hits         7522     7523    +1     
  Misses       1816     1816           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mcara
Copy link
Copy Markdown
Member Author

mcara commented Mar 7, 2026

Although regression tests fail, it is actually just one unit test that is failing and, based on the line numbers in the traceback, it looks like unit tests (when run as part of the entire regression test) do not use install overrides and so they do not use required package versions by tweakwcs and stcal.

@mcara
Copy link
Copy Markdown
Member Author

mcara commented Mar 7, 2026

Last commit (only temporary, to illustrate the last point) sets dependency to spacetelescope/stcal#529 and the regression tests with this commit are: https://github.com/spacetelescope/RegressionTests/actions/runs/22793185624

@mcara
Copy link
Copy Markdown
Member Author

mcara commented Mar 11, 2026

Tests are going to fail until the stcal and tweakreg PRs are merged. In a similar PR for romancal, once I modified pyproject.toml thests passes (they were failing with the same error): #2219

@mcara
Copy link
Copy Markdown
Member Author

mcara commented Mar 11, 2026

If you want, I can make a temporary commit to make them pass (it will need to be dropped before merging)

@schlafly
Copy link
Copy Markdown
Collaborator

I'm okay with either a temporary commit or a link to passing regression tests. The approach you're taking here looks reasonable to me and I'm happy to move forward with it, pending your deciding which of the various options is the best. Thanks!

@mcara mcara marked this pull request as draft March 11, 2026 19:44
Copy link
Copy Markdown
Collaborator

@mairanteodoro mairanteodoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks, Mihai!

I can approve once all the tests are passing.

@mcara mcara marked this pull request as ready for review March 18, 2026 13:48
@mcara mcara force-pushed the move-corrector-to-roman-pipeline branch from 03401d0 to 15f46ca Compare March 19, 2026 07:14
Copy link
Copy Markdown
Collaborator

@PaulHuwe PaulHuwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file tweak_reg tweakreg

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants