Conversation
The concise dictionary prefers `撮 ㄘㄨㄛˋ` Ref: https://dict.concised.moe.edu.tw/search.jsp?md=1&word=%E6%92%AE#searchL
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
There was a problem hiding this comment.
Pull request overview
Updates phrase-level Bopomofo mappings to align phrases containing 撮 with the Concised Dictionary preference of ㄘㄨㄛˋ.
Changes:
- Add ㄘㄨㄛˋ variants for multiple existing phrases containing 撮 (e.g., 一小撮、一撮、撮合、撮要).
- Add a tone-less ㄘㄨㄛ variant for 公撮 alongside the existing ㄘㄨㄛˋ entry.
| 一小撮 ㄧ ㄒㄧㄠˇ ㄘㄨㄛ | ||
| 一小撮 ㄧ ㄒㄧㄠˇ ㄘㄨㄛˋ | ||
| 一小撮 ㄧˋ ㄒㄧㄠˇ ㄘㄨㄛ | ||
| 一小撮 ㄧˋ ㄒㄧㄠˇ ㄘㄨㄛˋ |
There was a problem hiding this comment.
The PR description says the preferred reading for 撮 is ㄘㄨㄛˋ, but these entries keep the existing tone-less ㄘㄨㄛ (i.e. Tone 1) mappings and add ㄘㄨㄛˋ as an additional variant. Because both variants will have the same phrase frequency, the system may still treat the tone-less version as the default reading (e.g., when resolving a phrase’s reading by value), so this may not actually "fix" the phonetics. Consider replacing the ㄘㄨㄛ entries with ㄘㄨㄛˋ (or otherwise ensuring ㄘㄨㄛˋ is the preferred/default reading) rather than keeping both with equal weight.
| 一撮 ㄧ ㄘㄨㄛ | ||
| 一撮 ㄧ ㄘㄨㄛˋ | ||
| 一撮 ㄧˋ ㄘㄨㄛ | ||
| 一撮 ㄧˋ ㄘㄨㄛˋ |
There was a problem hiding this comment.
Same issue as above: keeping both ㄘㄨㄛ and ㄘㄨㄛˋ for the same phrase with identical frequency can cause the tone-less reading to remain the default, which conflicts with the stated preference for ㄘㄨㄛˋ. If ㄘㄨㄛ is not intended as a valid reading here, replace it with ㄘㄨㄛˋ instead of adding a second line.
| 公撮 ㄍㄨㄥ ㄘㄨㄛ | ||
| 公撮 ㄍㄨㄥ ㄘㄨㄛˋ |
There was a problem hiding this comment.
This change adds a tone-less ㄍㄨㄥ ㄘㄨㄛ entry alongside the existing ㄍㄨㄥ ㄘㄨㄛˋ entry. If the goal is to prefer ㄘㄨㄛˋ per the PR description, adding the tone-less variant can reintroduce the undesired default reading (and may be selected as the preferred reading in tie cases). Consider removing/replacing the tone-less entry so ㄘㄨㄛˋ remains the only (or clearly preferred) reading.
| 撮口呼 ㄘㄨㄛ ㄎㄡˇ ㄏㄨ | ||
| 撮口呼 ㄘㄨㄛˋ ㄎㄡˇ ㄏㄨ | ||
| 撮合 ㄘㄨㄛ ㄏㄜˊ | ||
| 撮合 ㄘㄨㄛˋ ㄏㄜˊ | ||
| 撮和 ㄘㄨㄛ ㄏㄜˊ | ||
| 撮和 ㄘㄨㄛˋ ㄏㄜˊ | ||
| 撮弄 ㄘㄨㄛ ㄋㄨㄥˋ | ||
| 撮弄 ㄘㄨㄛˋ ㄋㄨㄥˋ | ||
| 撮要 ㄘㄨㄛ ㄧㄠˋ | ||
| 撮要 ㄘㄨㄛˋ ㄧㄠˋ |
There was a problem hiding this comment.
These phrases now have duplicate readings differing only by the tone marker on 撮 (ㄘㄨㄛ vs ㄘㄨㄛˋ). If ㄘㄨㄛˋ is intended to be the correct/preferred reading, keeping the tone-less variants can leave the incorrect tone as the default in downstream reading resolution (ties by score/order). Consider changing the existing ㄘㄨㄛ mappings to ㄘㄨㄛˋ rather than adding parallel entries.
|
@xatier Thanks for the PRs! FYI, I've turned off automatic Copilot code review as a lot of those are just busy work. |
|
@lukhnos sounds good! I also find little value from these bot reviews for dictionary update PRs. Perhaps this is where human reviews still shine :D |
The concise dictionary prefers
撮 ㄘㄨㄛˋRef: https://dict.concised.moe.edu.tw/search.jsp?md=1&word=%E6%92%AE#searchL