Fix empty NavDisplay backstack by removing redundant onBack calls#523
Merged
rteyssandier merged 2 commits intoMay 12, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes redundant onBack() calls in PanelScene.kt to prevent double-navigation when hiding a panel. The reviewer noted a similar issue in the EscapeHandler of FloconPanel.kt that should be addressed to prevent potential crashes when closing the panel with the Escape key.
rteyssandier
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting with version 1.8.0 of Flocon everytime the
Panelis closed anIllegalArgumentExceptionis thrown:This should be related to the fact that
onBackwas triggered multiple times. Removing it from theonClickcallbacks fixes this issue.