Skip to content

feat: provide otel community demo attribute for service.criticality#2950

Open
bachgarash wants to merge 1 commit intoopen-telemetry:mainfrom
bachgarash:feat/prototype-service-criticality
Open

feat: provide otel community demo attribute for service.criticality#2950
bachgarash wants to merge 1 commit intoopen-telemetry:mainfrom
bachgarash:feat/prototype-service-criticality

Conversation

@bachgarash
Copy link
Copy Markdown

@bachgarash bachgarash commented Feb 2, 2026 •
edited
Loading

Changes

This PR includes newly introduced attribute - service.criticality to demo

Implements open-telemetry/semantic-conventions#3088

Merge Requirements

For new features contributions, please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs
  • Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

@bachgarash bachgarash requested a review from a team as a code owner February 2, 2026 18:26
@bachgarash bachgarash force-pushed the feat/prototype-service-criticality branch from 32fa7ba to 56e4121 Compare February 2, 2026 18:26
@github-actions github-actions bot added the helm-update-required Requires an update to the Helm chart when released label Feb 2, 2026
puckpuck
puckpuck requested changes Feb 2, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@puckpuck puckpuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to apply similar changes to docker-compose-minimal.yaml

@julianocosta89
Copy link
Copy Markdown
Member

julianocosta89 commented Feb 2, 2026

Will this be part of SemConv 1.40.0?

@bachgarash
Copy link
Copy Markdown
Author

bachgarash commented Feb 3, 2026

Will this be part of SemConv 1.40.0?

Not entirely sure, I hope so

@bachgarash bachgarash force-pushed the feat/prototype-service-criticality branch 2 times, most recently from 06b3bc0 to b3e5e7f Compare February 4, 2026 09:03
@bachgarash bachgarash requested a review from puckpuck February 4, 2026 09:03
@bachgarash bachgarash force-pushed the feat/prototype-service-criticality branch 2 times, most recently from ac287de to 9624b09 Compare February 9, 2026 19:56
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 17, 2026

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Feb 17, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 26, 2026

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Feb 26, 2026
@horovits
Copy link
Copy Markdown
Contributor

horovits commented Feb 26, 2026

@julianocosta89 can you advise what it takes to have the new attribute implemented in the demo?

@horovits
Copy link
Copy Markdown
Contributor

horovits commented Feb 26, 2026

Will this be part of SemConv 1.40.0?

per (https://github.com/open-telemetry/semantic-conventions/releases/tag/v1.40.0) under Enhancements:

service: Add service.criticality attribute to classify services based on operational importance (open-telemetry/semantic-conventions#2986)

@github-actions github-actions bot removed the Stale label Feb 27, 2026
julianocosta89
julianocosta89 reviewed Mar 2, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@julianocosta89 julianocosta89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an entry on the CHANGELOG

@julianocosta89
Copy link
Copy Markdown
Member

julianocosta89 commented Mar 2, 2026

Will this be part of SemConv 1.40.0?

per (https://github.com/open-telemetry/semantic-conventions/releases/tag/v1.40.0) under Enhancements:

service: Add service.criticality attribute to classify services based on operational importance (open-telemetry/semantic-conventions#2986)

hey @horovits thx for pointing out.
I did see that last week, I just didn't have time to go through the PR.

Thx for the patience @bachgarash!
I've left 2 comments, and after them being addressed, we should be good to go!

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 10, 2026

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Mar 10, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 18, 2026

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Mar 18, 2026
@horovits
Copy link
Copy Markdown
Contributor

horovits commented Mar 18, 2026

Will this be part of SemConv 1.40.0?

per (https://github.com/open-telemetry/semantic-conventions/releases/tag/v1.40.0) under Enhancements:

service: Add service.criticality attribute to classify services based on operational importance (open-telemetry/semantic-conventions#2986)

hey @horovits thx for pointing out. I did see that last week, I just didn't have time to go through the PR.

Thx for the patience @bachgarash! I've left 2 comments, and after them being addressed, we should be good to go!

thanks @julianocosta89!
I'll let @bachgarash address the outstanding comments, so we can wrap it up

@bachgarash bachgarash force-pushed the feat/prototype-service-criticality branch from 36279a1 to 5ffd9e9 Compare March 21, 2026 08:46
bachgarash added a commit to bachgarash/opentelemetry.io that referenced this pull request Mar 21, 2026
@bachgarash
docs(demo): add tail-based sampling example using service.criticality
b766dc1 
  Add sample collector configuration demonstrating a better
  tail-based sampling policies based on the service.criticality
  resource attribute introduced in SemConv 1.40.0.

  Ref: open-telemetry/opentelemetry-demo#2950
@bachgarash bachgarash mentioned this pull request Mar 21, 2026
Open
4 tasks
@bachgarash bachgarash force-pushed the feat/prototype-service-criticality branch from 5ffd9e9 to df67a89 Compare March 23, 2026 11:55
@julianocosta89
Copy link
Copy Markdown
Member

julianocosta89 commented Mar 23, 2026

@bachgarash I'm at KubeCon this week, but I just wanted to share that I've used this PR in a presentation today at the Observability Day.

I'll take a look at your PR whenever I'm back at normal work

@horovits
Copy link
Copy Markdown
Contributor

horovits commented Mar 23, 2026

@bachgarash I'm at KubeCon this week, but I just wanted to share that I've used this PR in a presentation today at the Observability Day.

I'll take a look at your PR whenever I'm back at normal work

@julianocosta89 we want to see pictures of you featuring the PR on stage at Observability Day 🤩

@bachgarash
Copy link
Copy Markdown
Author

bachgarash commented Mar 23, 2026

@bachgarash I'm at KubeCon this week, but I just wanted to share that I've used this PR in a presentation today at the Observability Day.

I'll take a look at your PR whenever I'm back at normal work

Wow, now I am excited and curious to see it :)

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 31, 2026

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Mar 31, 2026
@bachgarash bachgarash force-pushed the feat/prototype-service-criticality branch from df67a89 to 96a2228 Compare March 31, 2026 06:15
@bachgarash bachgarash force-pushed the feat/prototype-service-criticality branch from 96a2228 to a50b9bb Compare March 31, 2026 06:57
@github-actions github-actions bot removed the Stale label Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@puckpuck puckpuck Awaiting requested review from puckpuck

@julianocosta89 julianocosta89 Awaiting requested review from julianocosta89

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

helm-update-required Requires an update to the Helm chart when released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bachgarash @julianocosta89 @horovits @puckpuck