feat: Add testing agent to help with testing#793
Merged
Conversation
Signed-off-by: Jonathan Stacks <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new custom GitHub Copilot agent focused on improving test stability and authoring patterns for the ngrok Kubernetes Operator, and documents its usage for maintainers.
Changes:
- Added
test-agentagent instructions covering Ginkgo/Gomega + envtest patterns and flake-reduction guidance. - Updated the agents README to list and document how to invoke the new test agent.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
.github/agents/test-agent.agent.md |
Introduces a testing-focused agent playbook (framework, repo test structure, flake causes, workflows). |
.github/agents/README.md |
Documents the new agent alongside existing agents and provides usage examples. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
alex-bezek
approved these changes
Mar 27, 2026
Signed-off-by: Jonathan Stacks <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
Author
|
@copilot apply changes based on the comments in this thread |
- Fix "flakey" -> "flaky" spelling in README.md and test-agent.agent.md
- Update Eventually/Consistently guidance to reflect actual repo patterns:
pass ctx to k8s client calls inside the body, use explicit timeout/interval
args instead of Eventually(ctx, ...) form
- Use GinkgoT().Context() in test templates instead of context.Background()
- Soften DeferCleanup/Label("slow") recommendations to reflect they are not
the predominant pattern in existing tests
- Update code template to use AfterEach for namespace cleanup and DeferCleanup
for per-resource cleanup, consistent with surrounding test patterns
Agent-Logs-Url: https://github.com/ngrok/ngrok-operator/sessions/b9bc6551-834c-4de8-bc1d-e31dc243b407
Co-authored-by: jonstacks <[email protected]>
Contributor
Applied all changes from the review thread in commit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GinkgoT().Context()+timeout, intervalargs pattern🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.