Skip to content

Change full install manifests to main#782

Open
sabrina-ngrok wants to merge 3 commits intomainfrom
sabrina/manifest-bundle
Open

Change full install manifests to main#782
sabrina-ngrok wants to merge 3 commits intomainfrom
sabrina/manifest-bundle

Conversation

@sabrina-ngrok
Copy link
Copy Markdown
Contributor

What

manifest-bundle.yaml not being updated

How

Existing GitHub action for this change branch to main

Breaking Changes

Are there any breaking changes in this PR?

@sabrina-ngrok sabrina-ngrok requested a review from a team as a code owner March 16, 2026 18:58
@github-actions github-actions bot added area/ci Issues/PRs relating to CI size/S Denotes a PR that changes 10-29 lines labels Mar 16, 2026
@alex-bezek alex-bezek requested a review from Copilot March 16, 2026 19:13
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the automation responsible for regenerating the repo’s manifest-bundle.yaml so it runs for changes targeting main, aiming to keep the “full install” manifest bundle in sync with Helm chart updates.

Changes:

  • Switch workflow trigger from a branch-specific push event to pull_request_target against main.
  • Add a paths filter to run only when helm/**/* changes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +4 to +8
pull_request_target:
branches:
- alex/single-manifest-file
# paths:
# - 'helm/**/*'
# pull_request_target:
# branches:
# - main
# paths:
# - 'helm/**/*'
- main
paths:
- 'helm/**/*'
# - 'helm/**/*'
- main
paths:
- 'helm/**/*'
Comment on lines 3 to +6
on:
push:
# TODO(operator-rename): Change this to main at some point so that we update the manifest bundle.
# This will need to be run post-release.
pull_request_target:
branches:
- alex/single-manifest-file
# paths:
# - 'helm/**/*'
# pull_request_target:
# branches:
# - main
# paths:
# - 'helm/**/*'
- main
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.35%. Comparing base (5f44c0a) to head (5810e9b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #782      +/-   ##
==========================================
- Coverage   51.80%   51.35%   -0.45%     
==========================================
  Files         101      101              
  Lines       11188    11188              
==========================================
- Hits         5796     5746      -50     
- Misses       4976     5013      +37     
- Partials      416      429      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@jonstacks jonstacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've had issues with using pull_request_target before. It can be a security foot gun if not handled properly since the permissions granted to it run within the context of our repo and not the fork's repo.

I think a good middle ground to unblock this for now and at least make sure we are keeping it up to date is to have a pre-flight check for it that runs on PRs like we do for go mod tidy in the main CI job and just fail the workflow if its not up to date.

@github-actions github-actions bot added size/M Denotes a PR that changes 30-99 lines and removed size/S Denotes a PR that changes 10-29 lines labels Apr 8, 2026
@sabrina-ngrok sabrina-ngrok requested a review from jonstacks April 8, 2026 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ci Issues/PRs relating to CI size/M Denotes a PR that changes 30-99 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants