Conversation
There was a problem hiding this comment.
Pull request overview
Updates the automation responsible for regenerating the repo’s manifest-bundle.yaml so it runs for changes targeting main, aiming to keep the “full install” manifest bundle in sync with Helm chart updates.
Changes:
- Switch workflow trigger from a branch-specific
pushevent topull_request_targetagainstmain. - Add a
pathsfilter to run only whenhelm/**/*changes.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| pull_request_target: | ||
| branches: | ||
| - alex/single-manifest-file | ||
| # paths: | ||
| # - 'helm/**/*' | ||
| # pull_request_target: | ||
| # branches: | ||
| # - main | ||
| # paths: | ||
| # - 'helm/**/*' | ||
| - main | ||
| paths: | ||
| - 'helm/**/*' |
| # - 'helm/**/*' | ||
| - main | ||
| paths: | ||
| - 'helm/**/*' |
| on: | ||
| push: | ||
| # TODO(operator-rename): Change this to main at some point so that we update the manifest bundle. | ||
| # This will need to be run post-release. | ||
| pull_request_target: | ||
| branches: | ||
| - alex/single-manifest-file | ||
| # paths: | ||
| # - 'helm/**/*' | ||
| # pull_request_target: | ||
| # branches: | ||
| # - main | ||
| # paths: | ||
| # - 'helm/**/*' | ||
| - main |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #782 +/- ##
==========================================
- Coverage 51.80% 51.35% -0.45%
==========================================
Files 101 101
Lines 11188 11188
==========================================
- Hits 5796 5746 -50
- Misses 4976 5013 +37
- Partials 416 429 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jonstacks
left a comment
There was a problem hiding this comment.
We've had issues with using pull_request_target before. It can be a security foot gun if not handled properly since the permissions granted to it run within the context of our repo and not the fork's repo.
I think a good middle ground to unblock this for now and at least make sure we are keeping it up to date is to have a pre-flight check for it that runs on PRs like we do for go mod tidy in the main CI job and just fail the workflow if its not up to date.
What
manifest-bundle.yaml not being updated
How
Existing GitHub action for this change branch to main
Breaking Changes
Are there any breaking changes in this PR?