ci: consolidate nix setup and drop nix develop --command wrappers#795
Merged
ci: consolidate nix setup and drop nix develop --command wrappers#795
Conversation
Signed-off-by: Jonathan Stacks <jonstacks@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR consolidates Nix + cache + direnv setup into a reusable composite GitHub Action and updates CI workflows to rely on direnv export gha so steps can run make … directly without nix develop --command … wrappers.
Changes:
- Add a new composite action (
.github/actions/nix-setup) to install Nix, configure the magic cache, and export the flake devShell environment into subsequent steps. - Update multiple workflows to use the new
nix-setupaction and replacenix develop --command make …withmake …. - Update the
build-and-testcomposite action to runmakedirectly (assuming the environment is already prepared bynix-setup).
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/helm_release.yaml | Use centralized nix-setup; run Helm setup via make directly. |
| .github/workflows/generate-full-install-manifests.yaml | Use centralized nix-setup; drop nix develop wrapper (but workflow trigger/checkout config needs correction). |
| .github/workflows/copilot-setup-steps.yml | Replace inline Nix/cache/direnv steps with centralized nix-setup. |
| .github/workflows/ci.yaml | Use centralized nix-setup across jobs; run make/go commands directly. |
| .github/actions/nix-setup/action.yaml | New composite action implementing the consolidated Nix + cache + direnv setup (currently has a YAML structure issue). |
| .github/actions/build-and-test/action.yaml | Remove nix develop --command wrappers and run make targets directly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
alex-bezek
approved these changes
Mar 27, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #795 +/- ##
=======================================
Coverage 51.52% 51.52%
=======================================
Files 101 101
Lines 11188 11188
=======================================
Hits 5765 5765
- Misses 5002 5004 +2
+ Partials 421 419 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
While working on our setup up Copilot Agent, I found that we can use
direnv export ghato put all of our nix provided tools on the path. I also noticed that we were installing nix and the cache action in many places. This makes it harder to update the versions of these actions across all of our workflows.How
direnv export gha, we no longer need to usenix develop --commandacross our actionsBreaking Changes
No, this should only impact CI