Add P155_Smartmeter

[Brommander]

No description provided.

[TD-er]

Maybe you could take a picture of the device you have (don't use pictures from the ebay page), as the ebay link may not remain to work forever.

[TD-er]

dev.Type               = DEVICE_TYPE_SERIAL;

Also please use auto& dev = Device[++deviceCount]; and then replace Device[deviceCount] with dev

[TD-er]

Ehh this should be using a configuration to select a port.
Please search the code for ESPEasySerial, as used in plugins like P052/P053/P054 etc.
Not all ESP boards have the same pins accessible.
For example on ESP32-classic exactly these 2 pins have issues as they can also be used for PSRAM. Even on a board without PSRAM these pins will show high frequency signals every now and then.
I noticed you are using ESPEasySerial to create the UART instance, but still using hard coded values.
When using the dev.type (in the PLUGIN_ADD) to be serial, you already have the selector present on the webpage.

Then you could add something like this:

    case PLUGIN_WEBFORM_SHOW_SERIAL_PARAMS:
    {
      String options_baudrate[6];

      for (int i = 0; i < 6; ++i) {
        options_baudrate[i] = String(p085_storageValueToBaudrate(i));
      }
      const FormSelectorOptions selector(6, options_baudrate);
      selector.addFormSelector(F("Baud Rate"), P085_BAUDRATE_LABEL, P085_BAUDRATE);
      addUnit(F("baud"));
      addFormNumericBox(F("Modbus Address"), P085_DEV_ID_LABEL, P085_DEV_ID, 1, 247);
      break;
    }

to fine-tune the serial config (taken as example from P085)

[TD-er]

These are macros, you should not assign fixed values here.

      const int16_t serial_rx      = CONFIG_PIN1;
      const int16_t serial_tx      = CONFIG_PIN2;
      const ESPEasySerialPort port = static_cast<ESPEasySerialPort>(CONFIG_PORT);

[TD-er]

I think the formula is %value%/1000

[TD-er]

Ditto

[TD-er]

Please use English, also in comments

[TD-er]

Usually we do have a PluginStruct for plugin runtime data so we can have multiple instances of a plugin.
Also this makes sure no unused global variables are allocated in memory. (like nearly everything below this line upto line 206)

But we can change this later.

[TD-er]

By calling this function, you essentially copy the string.
Better to use p155_dataStructD0(const String& xID, float xvalue) as declaration of the constructor.
And since you don't actually do anything with the arguments, it is even better to have the constructor like this:

 p155_dataStructD0(const String& xID, float xvalue) : p155_rxID(xID), value(xvalue) {}

[TD-er]

If you declare the int i outside the scope of the for loop, you will still know which i was handled.
So then you can have all the log related lines together and wrap them into #ifndef BUILD_NO_DEBUG and if (loglevelActiveFor(LOG_LEVEL_DEBUG))

[TD-er]

Why starting at 1 here? If you don't need that one, why have it declared in the p155_myDataD0 array?

[TD-er]

When assigning an int to a float type, you don't need these C-style casts

[TD-er]

Ditto

[TD-er]

This scalar only seems to be set once in the code.
So why not calculate the scalar value there and have the scalar be either 1.0f or powf(10.0f, X) with X being the scalar value.

[TD-er]

There is no check for the range of the arrays

[TD-er]

Arrays are not initialized.

char p155_rxBuffer[P155_RX_BUFFER]{};
char p155_ringBuffer[8]{};
byte p155_rxOrbis[6]{}; //|1|0|2|8|0|255

Adding {} will initialize them with all zeroes.

[TD-er]

Int values also not initialized.

int p155_anzBytes{};
int p155_posDataAct{};
int p155_registerAct{};
int p155_outputOptionsAct{};

This will initialize them with zeroes.

[TD-er]

Please use functions like timePassedSince() so we can be sure those time calculations are done correct.
Otherwise you may get odd errors every 49.7 days :)

Also available() can be a rather expensive function, so maybe better to store it before making the while loop and if there is time left, you can do another check for available().

const unsigned long start = millis();
size_t available = P155_MySerial->available();
while (available && timePassedSince(start) < 10) {
  --available;
  if (available == 0) { available = P155_MySerial->available(); }
...

[TD-er]

There is no check for p155_charsRead < NR_ELEMENTS(p155_rxBuffer)
Should be done at the start of the while loop. (or at the end as you may set this value to 0 in this loop)