feat(FR-2989): show image architecture in deployment revision views#7622
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
yomybaby
changed the title
4 tasks
yomybaby
force-pushed
the
worktree-revision-image-arch
branch
from
7457cb5 to
18b91ad
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds image architecture suffix to deployment revision views so users can disambiguate image variants (e.g. x86_64 vs aarch64) sharing the same canonical name. The image identifier now renders as canonicalName@architecture, matching conventions used elsewhere (e.g. ImageNodeSimpleTag, getImageFullName).
Changes:
DeploymentRevisionDetail: fragment selectsarchitecture; Image row renderscanonicalName@architecturewith copy text aligned.DeploymentRevisionHistoryTab: query selectsarchitecture; default-hidden Image column renders the same full path.- Regenerated Relay artifacts for all queries/mutations that spread
DeploymentRevisionDetail_revision.
Reviewed changes
Copilot reviewed 2 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| react/src/components/DeploymentRevisionDetail.tsx | Builds imageFullName from canonical name + architecture and renders it in the Image row. |
| react/src/components/DeploymentRevisionHistoryTab.tsx | Adds architecture to query and renders combined fullName in Image column. |
| react/src/generated/DeploymentRevisionDetail_revision.graphql.ts | Regenerated fragment type with architecture. |
| react/src/generated/DeploymentRevisionHistoryTabListQuery.graphql.ts | Regenerated query type with architecture. |
| react/src/generated/DeploymentRevisionHistoryTabActivateMutation.graphql.ts | Regenerated mutation artifact. |
| react/src/generated/DeploymentReplicasTabListQuery.graphql.ts | Regenerated query artifact. |
| react/src/generated/DeploymentListPageQuery.graphql.ts | Regenerated query artifact. |
| react/src/generated/DeploymentDetailPageQuery.graphql.ts | Regenerated query artifact. |
| react/src/generated/DeploymentAddRevisionModalAddMutation.graphql.ts | Regenerated mutation artifact. |
| react/src/generated/AdminDeploymentListPageQuery.graphql.ts | Regenerated query artifact. |
| react/src/generated/ProjectAdminDeploymentsPageQuery.graphql.ts | Regenerated query artifact. |
Files not reviewed (9)
- react/src/generated/AdminDeploymentListPageQuery.graphql.ts: Language not supported
- react/src/generated/DeploymentAddRevisionModalAddMutation.graphql.ts: Language not supported
- react/src/generated/DeploymentDetailPageQuery.graphql.ts: Language not supported
- react/src/generated/DeploymentListPageQuery.graphql.ts: Language not supported
- react/src/generated/DeploymentReplicasTabListQuery.graphql.ts: Language not supported
- react/src/generated/DeploymentRevisionDetail_revision.graphql.ts: Language not supported
- react/src/generated/DeploymentRevisionHistoryTabActivateMutation.graphql.ts: Language not supported
- react/src/generated/DeploymentRevisionHistoryTabListQuery.graphql.ts: Language not supported
- react/src/generated/ProjectAdminDeploymentsPageQuery.graphql.ts: Language not supported
yomybaby
force-pushed
the
worktree-revision-folder-identicon
branch
from
676a1b4 to
20de2f7
Compare
yomybaby
force-pushed
the
worktree-revision-image-arch
branch
from
18b91ad to
71bd372
Compare
Contributor
Coverage Report for react-coverage (./react)
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
yomybaby
requested review from
agatha197 and
ironAiken2
and removed request for
ironAiken2
Merge activity
|
…7622) Resolves #7621 (FR-2989) Stacked on #7618 ## Summary In the deployment revision views, the image identifier was rendered as only `canonicalName` (`registry/namespace:tag`), omitting the architecture suffix. When multiple architectures (e.g. `x86_64`, `aarch64`) coexist for the same canonical name, it was ambiguous which image variant a revision is pinned to. This PR renders the full image path `canonicalName@architecture` instead, matching the convention used elsewhere in the app (e.g. `ImageNodeSimpleTag`, `ServiceLauncherPageContent`). - `DeploymentRevisionDetail` (Current Revision card and Revision Detail Drawer): Image row shows `canonicalName@architecture`. - `DeploymentRevisionHistoryTab`: the (default-hidden) Image column renders the same full path. - Both queries/fragments add `architecture` to `imageV2.identity`. ## Test plan - [ ] On `http://10.122.10.107:8090`, open a deployment with a current revision: the Image row shows `registry/namespace:tag@architecture`. - [ ] Open the Revision History tab → click a row → the drawer's Image row shows the same full path. - [ ] Enable the (default-hidden) Image column in Revision History → values include the `@architecture` suffix. - [ ] `bash scripts/verify.sh` — Relay/Lint/Format pass; TypeScript phantom worktree errors only (no errors in touched files).
graphite-app
Bot
force-pushed
the
worktree-revision-folder-identicon
branch
from
20de2f7 to
bdb95cd
Compare
graphite-app
Bot
force-pushed
the
worktree-revision-image-arch
branch
from
71bd372 to
3c2c1be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #7621 (FR-2989)
Stacked on #7618
Summary
In the deployment revision views, the image identifier was rendered as only
canonicalName(registry/namespace:tag), omitting the architecture suffix. When multiple architectures (e.g.x86_64,aarch64) coexist for the same canonical name, it was ambiguous which image variant a revision is pinned to.This PR renders the full image path
canonicalName@architectureinstead, matching the convention used elsewhere in the app (e.g.ImageNodeSimpleTag,ServiceLauncherPageContent).DeploymentRevisionDetail(Current Revision card and Revision Detail Drawer): Image row showscanonicalName@architecture.DeploymentRevisionHistoryTab: the (default-hidden) Image column renders the same full path.architecturetoimageV2.identity.Test plan
http://10.122.10.107:8090, open a deployment with a current revision: the Image row showsregistry/namespace:tag@architecture.@architecturesuffix.bash scripts/verify.sh— Relay/Lint/Format pass; TypeScript phantom worktree errors only (no errors in touched files).