feat(FR-2987): VFolder identicon in revision detail; drop image ID from history#7618
Merged
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
4 tasks
yomybaby
force-pushed
the
worktree-revision-folder-identicon
branch
from
676a1b4 to
20de2f7
Compare
Contributor
Coverage Report for react-coverage (./react)
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||
agatha197
requested changes
May 28, 2026
Merge activity
|
…om history (#7618) Resolves #7617 (FR-2987) ## Summary - Replace the generic `FolderOutlined` icon next to the Model Folder link in `DeploymentRevisionDetail` with `VFolderNodeIdenticon`. This affects both the Current Revision card and the Revision Detail Drawer (they share the same component) and applies to Additional Mounts entries as well. The folder name remains a `FolderLink` that opens the folder explorer when clicked. - In `DeploymentRevisionHistoryTab`, drop the trailing `(<BAIId globalId={imageV2.id} />)` from the Image column — only the canonical image name is shown now. The id had no user-facing value next to the canonical name. ## Test plan - [ ] On `http://10.122.10.107:8090`, open a deployment that has a current revision: the Model Folder row shows the VFolder identicon next to the folder name, and clicking the name opens the folder explorer. - [ ] Open the Revision History tab → click a row → the drawer's Model Folder row also shows the identicon; Additional Mounts entries show the identicon next to each mounted folder name. - [ ] Enable the (default-hidden) Image column in Revision History → only the canonical image name is shown, no `(uuid)` suffix. - [ ] `bash scripts/verify.sh` — Relay/Lint/Format pass; TypeScript phantom worktree errors only (no errors in the touched files).
graphite-app
Bot
force-pushed
the
worktree-revision-folder-identicon
branch
from
20de2f7 to
bdb95cd
Compare
graphite-app Bot
pushed a commit
that referenced
this pull request
May 28, 2026
…7622) Resolves #7621 (FR-2989) Stacked on #7618 ## Summary In the deployment revision views, the image identifier was rendered as only `canonicalName` (`registry/namespace:tag`), omitting the architecture suffix. When multiple architectures (e.g. `x86_64`, `aarch64`) coexist for the same canonical name, it was ambiguous which image variant a revision is pinned to. This PR renders the full image path `canonicalName@architecture` instead, matching the convention used elsewhere in the app (e.g. `ImageNodeSimpleTag`, `ServiceLauncherPageContent`). - `DeploymentRevisionDetail` (Current Revision card and Revision Detail Drawer): Image row shows `canonicalName@architecture`. - `DeploymentRevisionHistoryTab`: the (default-hidden) Image column renders the same full path. - Both queries/fragments add `architecture` to `imageV2.identity`. ## Test plan - [ ] On `http://10.122.10.107:8090`, open a deployment with a current revision: the Image row shows `registry/namespace:tag@architecture`. - [ ] Open the Revision History tab → click a row → the drawer's Image row shows the same full path. - [ ] Enable the (default-hidden) Image column in Revision History → values include the `@architecture` suffix. - [ ] `bash scripts/verify.sh` — Relay/Lint/Format pass; TypeScript phantom worktree errors only (no errors in touched files).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #7617 (FR-2987)
Summary
FolderOutlinedicon next to the Model Folder link inDeploymentRevisionDetailwithVFolderNodeIdenticon. This affects both the Current Revision card and the Revision Detail Drawer (they share the same component) and applies to Additional Mounts entries as well. The folder name remains aFolderLinkthat opens the folder explorer when clicked.DeploymentRevisionHistoryTab, drop the trailing(<BAIId globalId={imageV2.id} />)from the Image column — only the canonical image name is shown now. The id had no user-facing value next to the canonical name.Test plan
http://10.122.10.107:8090, open a deployment that has a current revision: the Model Folder row shows the VFolder identicon next to the folder name, and clicking the name opens the folder explorer.(uuid)suffix.bash scripts/verify.sh— Relay/Lint/Format pass; TypeScript phantom worktree errors only (no errors in the touched files).