Forbid pushing to origin in AGENTS.md#5344
Forbid pushing to origin in AGENTS.md#5344AntoineRichard wants to merge 2 commits intoisaac-sim:developfrom
Conversation
The origin remote points to the public isaac-sim/IsaacLab repo. Agents and contributors should push to their own fork remote or to the remote of the PR they are working on instead.
The workflow now explicitly requires running pre-commit checks before pushing, not just before committing. Adds a "don't push before running pre-commit" warning to the common mistakes list.
Greptile SummaryThis PR updates Confidence Score: 5/5Safe to merge — documentation-only change with no source or config modifications. All changes are prose additions to AGENTS.md. Both new guidelines (no-push-to-origin and pre-commit workflow) are correct, consistent with the project's custom rules, and have no correctness risk. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Make code changes] --> B[Run ./isaaclab.sh -f]
B --> C{Pre-commit modified files?}
C -- Yes --> D[Review changes & git add]
D --> E[Run ./isaaclab.sh -f again]
E --> F{All checks pass?}
F -- No --> B
F -- Yes --> G[git commit]
G --> H{Push target?}
H -- fork/PR remote --> I[git push your-fork branch]
H -- origin --> J[FORBIDDEN: Do not push to origin - isaac-sim/IsaacLab is public upstream]
Reviews (1): Last reviewed commit: "Enforce pre-commit before pushing in AGE..." | Re-trigger Greptile |
There was a problem hiding this comment.
🤖 Isaac Lab Review Bot
Summary
This PR adds two important safety guidelines to AGENTS.md: (1) requiring pre-commit checks before pushing (not just before committing), and (2) prohibiting pushes to origin (the upstream repo). The implementation is clean and follows existing document conventions.
Architecture Impact
No cross-module impact — changes are self-contained documentation updates to AGENTS.md.
Implementation Verdict
Ship it — Clean, well-written documentation improvements that add valuable safety guardrails for AI agents and contributors.
Test Coverage
Documentation-only change — no tests required.
CI Status
All checks passing ✅
Findings
No issues found. The changes are clear, actionable, and consistent with the document's existing style.
Description
The origin remote points to the public isaac-sim/IsaacLab repo. Agents and contributors should push to their own fork remote or to the remote of the PR they are working on instead.
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there