Skip to content

chore(iota-json-rpc-types): simplify IotaTransactionBlockKind::try_from_with_package_resolver #11478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thibault-martinez wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

chore(iota-json-rpc-types): simplify IotaTransactionBlockKind::try_from_with_package_resolver #11478

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59baafe
chore(iota-json-rpc-types): simplify `IotaTransactionBlockKind::try_f…
thibault-martinez May 8, 2026
f8094a9
Merge branch 'develop' into simplify-try_from_with_package_resolver
thibault-martinez May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 5 additions & 26 deletions crates/iota-json-rpc-types/src/iota_transaction.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -617,37 +617,16 @@ impl IotaTransactionBlockKind {
package_resolver: &Resolver<impl PackageStore>,
tx_digest: TransactionDigest,
) -> Result<Self, anyhow::Error> {
Ok(match tx {
TransactionKind::Genesis(g) => Self::Genesis(IotaGenesisTransaction {
objects: g.objects.iter().map(GenesisObject::id).collect(),
events: g
.events
.into_iter()
.enumerate()
.map(|(seq, _event)| EventID::from((tx_digest, seq as u64)))
.collect(),
}),
TransactionKind::ConsensusCommitPrologueV1(p) => {
Self::ConsensusCommitPrologueV1(IotaConsensusCommitPrologueV1 {
epoch: p.epoch,
round: p.round,
sub_dag_index: p.sub_dag_index,
commit_timestamp_ms: p.commit_timestamp_ms,
consensus_commit_digest: p.consensus_commit_digest,
consensus_determined_version_assignments: p
.consensus_determined_version_assignments
.into(),
})
}
TransactionKind::Programmable(p) => Self::ProgrammableTransaction(
match tx {
TransactionKind::Programmable(p) => Ok(Self::ProgrammableTransaction(
IotaProgrammableTransactionBlock::try_from_with_package_resolver(
p,
package_resolver,
)
.await?,
),
tx => Self::try_from_inner(tx, tx_digest)?,
})
)),
tx => Self::try_from_inner(tx, tx_digest),
}
}

pub fn transaction_count(&self) -> usize {
Expand Down
Loading