chore(iota-json-rpc-types): simplify IotaTransactionBlockKind::try_from_with_package_resolver#11478
Open
thibault-martinez wants to merge 2 commits intodevelopfrom
Open
chore(iota-json-rpc-types): simplify IotaTransactionBlockKind::try_from_with_package_resolver#11478thibault-martinez wants to merge 2 commits intodevelopfrom
IotaTransactionBlockKind::try_from_with_package_resolver#11478thibault-martinez wants to merge 2 commits intodevelopfrom
Conversation
…rom_with_package_resolver`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Simplify
IotaTransactionBlockKind::try_from_with_package_resolverby deduplicating theGenesisandConsensusCommitPrologueV1arms, which were copy-pasted fromtry_from_inner. The function now matches the shape of its siblingtry_from_with_module_cache: only theProgrammablevariant needs special handling (since it's the only one that requires the resolver), and everything else delegates totry_from_inner.No behavior change — the removed arms produced identical output to the
try_from_innerfallback they shadowed.Links to any relevant issues
N/A
How the change has been tested