Skip to content

chore(iota-json-rpc-types): simplify IotaTransactionBlockKind::try_from_with_package_resolver#11478

Open
thibault-martinez wants to merge 2 commits intodevelopfrom
simplify-try_from_with_package_resolver
Open

chore(iota-json-rpc-types): simplify IotaTransactionBlockKind::try_from_with_package_resolver#11478
thibault-martinez wants to merge 2 commits intodevelopfrom
simplify-try_from_with_package_resolver

Conversation

@thibault-martinez
Copy link
Copy Markdown
Member

Description of change

Simplify IotaTransactionBlockKind::try_from_with_package_resolver by deduplicating the Genesis and ConsensusCommitPrologueV1 arms, which were copy-pasted from try_from_inner. The function now matches the shape of its sibling try_from_with_module_cache: only the Programmable variant needs special handling (since it's the only one that requires the resolver), and everything else delegates to try_from_inner.

No behavior change — the removed arms produced identical output to the try_from_inner fallback they shadowed.

Links to any relevant issues

N/A

How the change has been tested

  • Basic tests (linting, compilation, formatting, unit/integration tests)
  • Patch-specific tests (correctness, functionality coverage) — pure refactor, covered by existing tests
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@iota-ci iota-ci added dev-tools Issues related to the Developer Tools Team sc-platform Issues related to the Smart Contract Platform group. labels May 8, 2026
@thibault-martinez thibault-martinez marked this pull request as ready for review May 8, 2026 16:08
@thibault-martinez thibault-martinez requested a review from a team as a code owner May 8, 2026 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev-tools Issues related to the Developer Tools Team sc-platform Issues related to the Smart Contract Platform group.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants