[Fix] : Template issue

[pankhur94]

Removes @itwin/presentation-core-interop as direct dep and override for metadependencies to 1.3.1.

[pankhur94]

I could not find any instance of direct usage of the package @itwin/presentation-core-interop directly in the app and hence took the liberty to remove it. If we need it as a direct dep, we would have to ask the user to manually change it to 1.3.1 as bentley react scripts prefixes "^" which leads to conflict with the override here. This is standard behaviour of npm until we explicitly specify --save-exact while running npm install or add save-prefix= in .npmrc file. The user would then have to manually add below in package.json as well before npm install.

overrides : {
"@itwin/presentation-core-interop": "1.3.1"
}

[aruniverse]

@itwin/presentation-core-interop must be a peer dep of some other pkg, which is why we need to include it in our end
Review the blame here: https://github.com/iTwin/viewer/blame/master/packages/templates/cra-template-web-viewer/template.json#L30

[pankhur94]

@itwin/presentation-core-interop must be a peer dep of some other pkg, which is why we need to include it in our end Review the blame here: https://github.com/iTwin/viewer/blame/master/packages/templates/cra-template-web-viewer/template.json#L30

I did check and found out that it was added in this commit. However I could not find any of the other dependencies added/updated to have it as a peer-dependency. To confirm I ran npm ls @itwin/presentation-core-interop --all in the newly created app and did not find @itwin/presentation-core-interop to be a peer dependency in any of the deps either.

Also, it is not listed as a peer dependency in any of our deps in package-lock.json.

[grigasp]

I agree, it looks like it's unnecessary, I think adding it was just an oversight.

However, I don't understand why the following part is necessary:

    "overrides": {
      "@itwin/presentation-core-interop": "1.3.1"
    }

[pankhur94]

I agree, it looks like it's unnecessary, I think adding it was just an oversight.

However, I don't understand why the following part is necessary:

    "overrides": {
      "@itwin/presentation-core-interop": "1.3.1"
    }

introduction of checking SchemaFormatsProviders here in 1.3.2 is causing errors in viewer since webpack tries to statically resolve all imports. Hence, we need to make sure we use 1.3.1 to fix this error.
We can remove this once we have moved completely to use 5.0

[aruniverse]

But how are these overrides applied? does npm automatically apply them?

[pankhur94]

But how are these overrides applied? does npm automatically apply them?

yes, that is right, npm understands overrides and when it does npm install, it applies them.