[ Fix ]: Desktop viewer template fix#364
Merged
Conversation
Contributor
pankhur94
commented
May 26, 2025
pankhur94
commented
- Fixed in web-viewer in this.
- Removes @itwin/presentation-core-interop as dependency and overrides with version 1.3.1.
pankhur94
requested review from
aruniverse,
ben-polinsky and
calebmshafer
as code owners
ben-polinsky
approved these changes
May 27, 2025
aruniverse
added a commit
that referenced
this pull request
Jun 11, 2025
* point to new reality data endpoint (#345) * point to new reality data endpoint * rush change --------- Co-authored-by: Arun George <aruniverse@users.noreply.github.com> * Update changelogs [skip ci] * Bump versions [skip ci] * mitigate audit GHSA-rhx6-c78j-4q9w (#347) Co-authored-by: Ben Polinsky <ben-polinsky@users.noreply.github.com> * remove custom audit script, resolve GHSA-jr5f-v2jv-69x6 (#348) * remove custom audit script, resolve GHSA-jr5f-v2jv-69x6 * suppress deprecations for now, will fix on 5.0 --------- Co-authored-by: Arun George <aruniverse@users.noreply.github.com> * Stop using deprecated selection APIs (#346) * update dependencies * change usage of to * update property widget to the latest, supply it the unified selection storage * allow specifying selection scope props * update selected items count without using deprecated apis * downgrade `@itwin/unified-selection` dependency to `~1.1.2` * change * prettier * fix tests * Extract nested selection scope props type into , define unified selection props using type helper * fix change messages * update lockfile --------- Co-authored-by: Ben Polinsky <78756012+ben-polinsky@users.noreply.github.com> Co-authored-by: Arun George <aruniverse@users.noreply.github.com> * Update changelogs [skip ci] * Bump versions [skip ci] * Fix desktop template build issue (#349) * Fix desktop app build issue * rush change * Update changelogs [skip ci] * Bump versions [skip ci] * Add missing peer dependencies (#356) * Add missing peer dependencies * rush change * Update changelogs [skip ci] * Bump versions [skip ci] * [Fix]: iTwin Viewer template issue (#359) * adding unified-selection-react as dep * rush change * adding comment and type to rush change * Update changelogs [skip ci] * Bump versions [skip ci] * [Fix] : Template issue (#361) * removing presentation-core-interop as direct dep, adding override to version 1.3.1 * rush change * Update changelogs [skip ci] * Bump versions [skip ci] * [ Fix ]: Desktop viewer template fix (#364) * removing @itwin/presentation-core-interop and overriding version 1.3.1 * rush change * fixing comment in json * Update changelogs [skip ci] * Bump versions [skip ci] * web and desktop template fix * update unified-selection, browser-authorization, fix lint * updating deps * update and clean deps, fix context * comments resolved --------- Co-authored-by: Arun George <11051042+aruniverse@users.noreply.github.com> Co-authored-by: Arun George <aruniverse@users.noreply.github.com> Co-authored-by: imodeljs-admin <imodeljs-admin@users.noreply.github.com> Co-authored-by: Ben Polinsky <78756012+ben-polinsky@users.noreply.github.com> Co-authored-by: Ben Polinsky <ben-polinsky@users.noreply.github.com> Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com> Co-authored-by: Gytis Čepkauskas <98940208+GytisCepk@users.noreply.github.com> Co-authored-by: Saulius Skliutas <24278440+saskliutas@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.