Skip to content

Fixing lint for CI pass#358

Merged
aruniverse merged 5 commits intonextfrom
pankhur94/fixing-lint
May 12, 2025
Merged

Fixing lint for CI pass#358
aruniverse merged 5 commits intonextfrom
pankhur94/fixing-lint

Conversation

@pankhur94
Copy link
Copy Markdown
Contributor

@pankhur94 pankhur94 commented May 6, 2025

This PR addresses and resolves existing linting errors across the codebase. In addition, it updates several ESLint-related dependencies to align with our current setup and improve compatibility.
Changes Include

  • Fixed lint errors reported by @typescript-eslint/parser
  • Updated ESLint configuration files to move to flat file format.
  • Upgraded the lint-related dependencies.

Comment thread common/scripts/package.json Outdated
Comment thread common/scripts/eslint.config.js Outdated
Comment thread common/scripts/eslint.base.config.js Outdated
Comment thread packages/apps/web-viewer-test/.env Outdated
Comment thread packages/modules/desktop-viewer-react/src/services/Initializer.ts
Comment thread packages/modules/desktop-viewer-react/tsconfig.json Outdated
Comment thread packages/modules/viewer-react/src/services/iModel/ViewCreator3d.ts Outdated
@pankhur94
Copy link
Copy Markdown
Contributor Author

pankhur94 commented May 7, 2025

the pre-commit has to be sorted. It is behaving pretty vaguely rn. I have to ignore it when committing the changes. Not sure if we should use --fix when committing. It should be ideally done by the changer by running lint:fix command if required.

Comment thread common/scripts/package.json Outdated
Comment thread common/scripts/eslint.config.js Outdated
Comment thread common/scripts/package.json Outdated
Comment thread packages/modules/viewer-react/tsconfig.json Outdated
Comment thread packages/modules/viewer-react/tsconfig.test.json Outdated
Comment thread common/scripts/package.json Outdated
@pankhur94 pankhur94 force-pushed the pankhur94/fixing-lint branch from 0cca61f to 17f5a11 Compare May 9, 2025 15:30
Comment thread packages/modules/viewer-react/tsconfig.test.json Outdated
@pankhur94 pankhur94 marked this pull request as ready for review May 12, 2025 16:01
@aruniverse aruniverse merged commit bfa5b6d into next May 12, 2025
2 checks passed
@aruniverse aruniverse deleted the pankhur94/fixing-lint branch May 12, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants