Fixing lint for CI pass (#358)

* lint fix

* adding deprecation supresser, updating plugins, indentation, updating config files

* fixing comments

* reverting to use tsconfig from build-tools

* removing tsconfig.test, updating ts

Author: pankhur94

.eslintignore

@@ -1,10 +1,13 @@
-{
-  "extends": ["./.eslintrc.ts.base.json"],
-  "rules": {
+const baseConfig = require("./eslint.base.config.js");
+
+module.exports = {
+  ...baseConfig,
+  rules: {
+    ...(baseConfig.rules),
     "simple-import-sort/sort": "error",
     "@typescript-eslint/no-inferrable-types": "error",
-    "curly": "error",
+    curly: "error",
     "react-hooks/exhaustive-deps": "off",
     "@typescript-eslint/consistent-type-imports": "error"
   }
-}
+};

common/config/rush/pnpm-lock.yaml

@@ -0,0 +1,57 @@
+const tsPlugin = require("@typescript-eslint/eslint-plugin");
+const tsParser = require("@typescript-eslint/parser");
+const react = require("eslint-plugin-react");
+const prettier = require("eslint-plugin-prettier");
+const simpleImportSort = require("eslint-plugin-simple-import-sort");
+const reactHooks = require("eslint-plugin-react-hooks");
+const iTwinPlugin = require("@itwin/eslint-plugin");
+const reactApp = require("eslint-config-react-app");
+
+module.exports = {
+  files: ["**/*.{ts,tsx}"],
+  ...iTwinPlugin.configs.iTwinjsRecommendedConfig,
+  languageOptions: {
+    ecmaVersion: 2022,
+    sourceType: "module",
+    parser: tsParser,
+    parserOptions: {
+      project: "./tsconfig.json",
+    },
+  },
+  plugins: {
+    "@typescript-eslint": tsPlugin,
+    react,
+    "simple-import-sort": simpleImportSort,
+    "react-hooks": reactHooks,
+    "react-app": reactApp,
+    prettier,
+  },
+  rules: {
+    ...react.configs.recommended.rules,
+    "no-console": "off",
+    "no-var": "error",
+    "import/prefer-default-export": "off",
+    radix: "off",
+    "@typescript-eslint/no-explicit-any": "off",
+    "@typescript-eslint/explicit-function-return-type": "off",
+    "@typescript-eslint/explicit-member-accessibility": "off",
+    "@typescript-eslint/explicit-module-boundary-types": "off",
+    "@typescript-eslint/interface-name-prefix": "off",
+    "react/no-unescaped-entities": "off",
+    "react/display-name": "off",
+    "react/prop-types": "off",
+    "no-unused-vars": "off",
+    "@typescript-eslint/no-unused-vars": ["warn", { ignoreRestSiblings: true }],
+    "@typescript-eslint/no-deprecated": "error",
+  },
+  settings: {
+    "import/resolver": {
+      node: {
+        extensions: [".js", ".jsx", ".ts", ".tsx"],
+      },
+    },
+    react: {
+      version: "detect",
+    }
+  }
+};  

common/scripts/.eslintrc.ts.base.json

@@ -0,0 +1,12 @@
+const baseConfig = require("./eslint.base.config.js");
+
+module.exports = {
+  ...baseConfig,
+  rules: {
+    ...(baseConfig.rules),
+    "@typescript-eslint/no-floating-promises": "error",
+    "@typescript-eslint/prefer-optional-chain": "warn",
+    "@typescript-eslint/prefer-nullish-coalescing": "warn",
+    "react-hooks/exhaustive-deps": "warn",
+  },
+};

common/scripts/.eslintrc.ts.json

@@ -5,28 +5,24 @@
   "license": "MIT",
   "repository": "https://github.com/itwin/viewer/tree/main/common/scripts",
   "devDependencies": {
-    "@typescript-eslint/eslint-plugin": "^4.5.0",
-    "@typescript-eslint/parser": "^4.5.0",
-    "eslint": "^7.11.0",
-    "eslint-config-airbnb": "^18.2.1",
-    "eslint-config-prettier": "^6.11.0",
-    "eslint-config-react-app": "^6.0.0",
-    "eslint-plugin-flowtype": "^5.2.0",
-    "eslint-plugin-deprecation": "1.2.1",
-    "eslint-plugin-import": "^2.22.0",
-    "eslint-plugin-jsx-a11y": "^6.3.1",
-    "eslint-plugin-prefer-arrow": "^1.1.7",
-    "eslint-plugin-prettier": "^3.1.4",
+    "@typescript-eslint/eslint-plugin": "^8.32.0",
+    "@typescript-eslint/parser": "^8.32.0",
+    "@itwin/eslint-plugin": "^5.1.0",
+    "eslint": "^9.13.0",
+    "eslint-config-prettier": "^10.0.1",
+    "eslint-config-react-app": "^7.0.0",
+    "eslint-plugin-prettier": "^5.4.0",
     "eslint-plugin-react": "^7.20.3",
-    "eslint-plugin-react-hooks": "^4.0.7",
-    "eslint-plugin-simple-import-sort": "^5.0.3",
-    "lint-staged": "^10.2.11",
-    "prettier": "^2.0.5",
-    "stylelint": "^13.6.1",
-    "stylelint-config-prettier": "^8.0.2",
-    "stylelint-config-sass-guidelines": "^7.0.0",
-    "stylelint-prettier": "^1.1.2",
-    "stylelint-scss": "^3.18.0"
+    "eslint-plugin-react-hooks": "^5.0.2",
+    "eslint-plugin-simple-import-sort": "^12.1.1",
+    "lint-staged": "^11.2.6",
+    "prettier": "^3.5.3",
+    "typescript-eslint": "^8.32.0",
+    "stylelint": "^16.19.1",
+    "stylelint-config-prettier": "^9.0.5",
+    "stylelint-config-sass-guidelines": "^12.1.0",
+    "stylelint-prettier": "^5.0.3",
+    "stylelint-scss": "^6.12.0"
   },
   "scripts": {
     "build": "",

common/scripts/.eslintrc.ts.autofix.json common/scripts/eslint.autofix.config.jscommon/scripts/.eslintrc.ts.autofix.json renamed to common/scripts/eslint.autofix.config.js

@@ -5,9 +5,9 @@ async function preCommit() {
     config: {
       "*.{ts,tsx}": [
         "node ./common/scripts/copyright-linter.js --",
-        "node --max_old_space_size=4096 ./common/scripts/node_modules/eslint/bin/eslint.js --config ./common/scripts/.eslintrc.ts.autofix.json --ignore-path ./.eslintignore --resolve-plugins-relative-to ./common/scripts --fix",
+        "node --max_old_space_size=4096 ./common/scripts/node_modules/eslint/bin/eslint.js --config ./common/scripts/eslint.autofix.config.js --ignore-pattern **/node_modules/** --fix",
         "node ./common/scripts/node_modules/prettier --write --config ./.prettierrc --ignore-path ./.prettierignore",
-        "node --max_old_space_size=4096 ./common/scripts/node_modules/eslint/bin/eslint.js --config ./common/scripts/.eslintrc.ts.json --ignore-path ./.eslintignore --color --resolve-plugins-relative-to ./common/scripts",
+        "node --max_old_space_size=4096 ./common/scripts/node_modules/eslint/bin/eslint.js --config ./common/scripts/eslint.autofix.config.js --ignore-pattern **/node_modules/** --color",
       ],
       "*.{md,json}": [
         "node ./common/scripts/node_modules/prettier --write --config ./.prettierrc --ignore-path ./.prettierignore",

common/scripts/eslint.base.config.js

@@ -0,0 +1,12 @@
+const config = require("../../../common/scripts/eslint.config.js");
+module.exports = {
+  ...config,
+  languageOptions: {
+    ...config.languageOptions,
+    parserOptions: {
+      ...config.languageOptions.parserOptions,
+      tsconfigRootDir: __dirname,
+      project: ["./tsconfig.json", "./tsconfig.backend.json"],
+    },
+  },
+};