wip: bisect the table-cleanup PR#2811
Open
gnosek wants to merge 90 commits intofalcosecurity:masterfrom
Open
Conversation
poiana
added
release-note-none
do-not-merge/work-in-progress
kind/cleanup
dco-signoff: yes
kind/feature
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gnosek The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Perf diff from master - unit testsHeap diff from master - unit testsHeap diff from master - scap fileBenchmarks diff from master |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #2811 +/- ##
==========================================
- Coverage 74.67% 74.55% -0.12%
==========================================
Files 292 295 +3
Lines 30597 30617 +20
Branches 4820 4811 -9
==========================================
- Hits 22847 22827 -20
- Misses 7750 7790 +40
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gnosek
force-pushed
the
table-cleanup-wip-bisect
branch
2 times, most recently
from
976672c to
c75e0b4
Compare
terror96
reviewed
Jan 29, 2026
userspace/libsinsp/plugin_tables.cpp
Outdated
| auto container_id_field_ptr = dynamic_cast<libsinsp::state::typed_accessor<std::string>*>( | ||
| container_id_field.release()); | ||
| if(container_id_field_ptr == nullptr) { | ||
| delete container_id_field_ptr; |
Contributor
There was a problem hiding this comment.
I guess this does nothing because container_id_field_ptr is nullptror ...
...and maybe something along the lines if this was the intention:
auto raw = container_id_field.release();
auto typed = dynamic_cast<libsinsp::state::typed_accessor<std::string>*>(raw);
if(typed == nullptr) {
delete raw; // delete the original pointer, not the cast result
throw ...;
}
m_container_id_field.reset(typed);
8aa0da8 to
c6289a2
Compare
gnosek
force-pushed
the
table-cleanup-wip-bisect
branch
from
c6f8de9 to
e4149de
Compare
Signed-off-by: Grzegorz Nosek <[email protected]>
The two obvious implementations are `static_struct` and `dynamic_struct`, but there's another one hiding inside the STL table adapter support code. Signed-off-by: Grzegorz Nosek <[email protected]>
Signed-off-by: Grzegorz Nosek <[email protected]>
Signed-off-by: Grzegorz Nosek <[email protected]>
This is a wrapper around both static_struct and dynamic_struct. Its purpose is to make life for types inheriting from both a little bit easier (no need to disambiguate parent method calls). Signed-off-by: Grzegorz Nosek <[email protected]>
Signed-off-by: Grzegorz Nosek <[email protected]>
Signed-off-by: Grzegorz Nosek <[email protected]>
Signed-off-by: Grzegorz Nosek <[email protected]>
Signed-off-by: Grzegorz Nosek <[email protected]>
Signed-off-by: Grzegorz Nosek <[email protected]>
Signed-off-by: Grzegorz Nosek <[email protected]>
Signed-off-by: Grzegorz Nosek <[email protected]>
Signed-off-by: Grzegorz Nosek <[email protected]>
Signed-off-by: Grzegorz Nosek <[email protected]>
Signed-off-by: Grzegorz Nosek <[email protected]>
Signed-off-by: Grzegorz Nosek <[email protected]>
Signed-off-by: Grzegorz Nosek <[email protected]>
Signed-off-by: Grzegorz Nosek <[email protected]>
Signed-off-by: Grzegorz Nosek <[email protected]>
Signed-off-by: Grzegorz Nosek <[email protected]>
Signed-off-by: Grzegorz Nosek <[email protected]>
Signed-off-by: Grzegorz Nosek <[email protected]>
Signed-off-by: Grzegorz Nosek <[email protected]>
Signed-off-by: Grzegorz Nosek <[email protected]>
Signed-off-by: Grzegorz Nosek <[email protected]>
Signed-off-by: Grzegorz Nosek <[email protected]>
Signed-off-by: Grzegorz Nosek <[email protected]>
Signed-off-by: Grzegorz Nosek <[email protected]>
Signed-off-by: Grzegorz Nosek <[email protected]>
Signed-off-by: Grzegorz Nosek <[email protected]>
gnosek
force-pushed
the
table-cleanup-wip-bisect
branch
3 times, most recently
from
7d76d8c to
9addef8
Compare
…nctions Signed-off-by: Grzegorz Nosek <[email protected]>
gnosek
force-pushed
the
table-cleanup-wip-bisect
branch
from
9addef8 to
7b9e370
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
/kind feature
Any specific area of the project related to this PR?
/area libsinsp
Does this PR require a change in the driver versions?
What this PR does / why we need it:
This PR serves as a CI runner for issues I can't repro locally. Don't mind me :)
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: