wip: make tid atomic

Signed-off-by: Grzegorz Nosek <grzegorz.nosek@sysdig.com>

Author: gnosek

test/libsinsp_e2e/thread_state.cpp

@@ -36,7 +36,7 @@ class thread_state_test : public ::testing::Test {
 		// Each entry in the vector has a parent of the previous
 		// entry. The first entry has a parent of 1.
 		for(int64_t pid = 100, i = 0; i < m_max; pid++, i++) {
-			int64_t ppid = (i == 0 ? 1 : m_threads[i - 1]->m_tid);
+			int64_t ppid = (i == 0 ? 1 : m_threads[i - 1]->m_tid.load());
 			std::unique_ptr<sinsp_threadinfo> thr = threadinfo_factory.create();
 			thr->init();
 			thr->m_tid = pid;
@@ -54,7 +54,7 @@ class thread_state_test : public ::testing::Test {
 	void reset() {
 		// Reset the state
 		for(uint32_t i = 0; i < m_max; i++) {
-			int64_t ppid = (i == 0 ? 1 : m_threads[i - 1]->m_tid);
+			int64_t ppid = (i == 0 ? 1 : m_threads[i - 1]->m_tid.load());
 			sinsp_threadinfo* tinfo = m_threads[i];
 			tinfo->m_lastevent_fd = 0;
 			tinfo->set_parent_loop_detected(false);

userspace/libsinsp/sinsp_debug/sinsp_debug.cpp

@@ -55,7 +55,7 @@ void display_thread_lineage(sinsp_thread_manager& thread_manager, sinsp_threadin
 		return true;
 	};
 
-	printf("📜 Task Lineage for tid: %" PRId64 "\n", tinfo->m_tid);
+	printf("📜 Task Lineage for tid: %" PRId64 "\n", tinfo->m_tid.load());
 	printf("⬇️ %s\n", thread_info_to_string(tinfo).c_str());
 
 	/* If the thread is invalid it has no parent */
@@ -147,7 +147,7 @@ int main(int argc, char** argv) {
 					auto child_shr = child.lock().get();
 					printf("- move child, tid: %" PRId64 ", ptid: %" PRId64
 					       " (dead) to a new reaper.\n",
-					       child_shr->m_tid,
+					       child_shr->m_tid.load(),
 					       child_shr->m_ptid);
 				}
 			}

userspace/libsinsp/thread_manager.cpp

@@ -249,7 +249,7 @@ const std::shared_ptr<sinsp_threadinfo>& sinsp_thread_manager::add_thread(
 				libsinsp_logger()->format(
 				        sinsp_logger::SEV_INFO,
 				        "Thread table full, dropping tid %lu (pid %lu, comm \"%s\")",
-				        threadinfo->m_tid,
+				        threadinfo->m_tid.load(),
 				        threadinfo->m_pid,
 				        threadinfo->m_comm.c_str());
 			}

userspace/libsinsp/threadinfo.cpp

@@ -51,7 +51,7 @@ libsinsp::state::static_field_infos sinsp_threadinfo::get_static_fields() {
 
 	libsinsp::state::static_field_infos ret;
 	// todo(jasondellaluce): support missing fields that are vectors, maps, or sub-tables
-	DEFINE_STATIC_FIELD(ret, self, m_tid, "tid");
+	DEFINE_STATIC_TYPED_FIELD(ret, self, m_tid, "tid", SS_PLUGIN_ST_INT64);
 	DEFINE_STATIC_FIELD(ret, self, m_pid, "pid");
 	DEFINE_STATIC_FIELD(ret, self, m_ptid, "ptid");
 	DEFINE_STATIC_FIELD(ret, self, m_reaper_tid, "reaper_tid");

userspace/libsinsp/threadinfo.h

@@ -351,7 +351,7 @@ class SINSP_PUBLIC sinsp_threadinfo : public libsinsp::state::extensible_struct
 	//
 	// Core state
 	//
-	int64_t m_tid;   ///< The id of this thread
+	std::atomic<int64_t> m_tid;  ///< The id of this thread
 	int64_t m_pid;   ///< The id of the process containing this thread. In single thread threads,
 	                 ///< this is equal to tid.
 	int64_t m_ptid;  ///< The id of the process that started this thread.