Fix: Chinese translations#146
Merged
eljojo merged 1 commit intoeljojo:mainfrom Apr 6, 2026
Merged
Conversation
gabrnavarro
changed the title
Owner
|
@gabrnavarro thanks for opening this PR! It seems that there's merge conflicts that need to be addressed, maybe your fork was out of date? |
Contributor
Author
|
Good catch! Just rebased against main and pushed the fix—should be all clear now. |
Signed-off-by: gabrnavarro <[email protected]>
gabrnavarro
force-pushed
the
fix/issue-96
branch
from
e8e0301 to
9a2b022
Compare
Owner
|
thank you @gabrnavarro! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Added Simplified Chinese (zh-CN) translations across all components:
recover,maker,readme,index,common, andhome. Also added thelang_zh-CNkey to every existing language's readme translation so the language name renders correctly in all READMEs.Registered
zh-CNintranslations.goalongside Traditional Chinese (zh-TW), with the display name "中文（简体）".Why
Addresses the request in issue #96 for a Simplified Chinese translation to make ReMemory accessible to mainland China users. Used the existing Traditional Chinese translation (
zh-TW) as a starting point and adapted the simplified characters and phrasing accordingly.Fixes #96
Testing
go test ./internal/translations/...— all translation tests pass, includingTestAllJSONFilesParseCorrectlywhich verifies every component/language combination loads and parses correctlygo test ./...— full test suite passesmake lint— clean