chore: remove node-pupeteer image for tests & fix release in dry-run mode#1683
chore: remove node-pupeteer image for tests & fix release in dry-run mode#1683david-luna merged 24 commits intomainfrom
node-pupeteer image for tests & fix release in dry-run mode#1683Conversation
🤖 GitHub commentsJust comment with:
|
david-luna
changed the title
david-luna
changed the title
node-pupeteer image for tests & fix release in dry-run mode
|
@vigneshshanmugam @trentm I you have time you review would be appreciated :) |
| } | ||
|
|
||
| await appendFile(path.join(process.cwd(), '.npmrc'), '\n' + npmrcData) | ||
| await execa( |
There was a problem hiding this comment.
note for reviewer: the previous method for creating a user and login was failing. This package (although it's old) gets the auth token right.
|
|
||
| ```sh | ||
| NODEJS_VERSION=<nodeVersion> STACK_VERSION=<version> docker compose -f ./dev-utils/docker-compose.yml up -d apm-server | ||
| NODEJS_VERSION=<nodeVersion> STACK_VERSION=<version> docker compose -f ./dev-utils/docker-compose.yml up -d fleet-server |
There was a problem hiding this comment.
note for reviewer: this command was wrong. apm-server service does not exist in the compose file
| describe('Sourcemaps', function () { | ||
| // This test is failing in CI and tested in Kibana repo | ||
| // ref: https://github.com/elastic/kibana/blob/main/x-pack/solutions/observability/plugins/apm/server/routes/fleet/source_maps.test.ts | ||
| xdescribe('Sourcemaps', function () { |
There was a problem hiding this comment.
note for reviewer: skipped test for now. Maybe remove it in the future?
There was a problem hiding this comment.
Arent we not exposing this endpoint?
| xhrSpan.end() | ||
| tr._start = transactionStart | ||
| tr.end() | ||
| tr.end(transactionEnd) |
There was a problem hiding this comment.
note for reviewer: without the end time test where failing locally because the transaction ended before the resource entries responseEnd time. This made the agent to discard al resource entries
| writeFileSync(pkgPath, pkgText.replace('"provenance": true', '"provenance": false')) | ||
|
|
||
| // And publish | ||
| await execa( |
There was a problem hiding this comment.
Did you validate if this works? Lerna publish ensures these are overriden
without NPM workspaces, i dont think it would work.
There was a problem hiding this comment.
Nope. I'll try the dryRun mode locally and see if the installation of the packages have any issues
3 participants
Dry run releases were failing. The reason is the recent change to use trusted publishers in #1651 which is not supported by Verdaccio (the service is used to test publishing).
This PR changes it to use regular
npm publish --registry {verdaccio_URL}to avoid OIDC fetch errors and also skpis the file uploads to Elastic's storagesUPDATE: I've leveraged this PR to also fix the CI errors we are having right now. ref: #1685
The approach taken is to remove the
node-puppeteerimage and rely in the CI node to run the tests and collect the coverage. Summary of the changesnode-puppeteerservice from./dev-utils/docker-compose.yml.ci/docker/node-puppeteerfolderrun-testaction from workflows