Skip to content

fix(release): set the dependencies versions when publishign in dry-run mode#1688

Closed
david-luna wants to merge 1 commit into
mainfrom
release-dry-run-locally
Closed

fix(release): set the dependencies versions when publishign in dry-run mode#1688
david-luna wants to merge 1 commit into
mainfrom
release-dry-run-locally

Conversation

@david-luna
Copy link
Copy Markdown
Member

Last release related PR #1683 had one thing missing which was pointed out by @vigneshshanmugam in #1683 (comment)

After several tests we can say:

  • dry-run mode is affected and packages are published with a file:.. reference in their dependencies
  • production mode is not affected since we are still using lerna for this mode

This PR is fixing the issue for the dry run mode which publish in a local verdaccio registry. I verified with the following steps:

  • start docker locally
  • run docker run -it --rm --name verdaccio -p 4873:4873 verdaccio/verdaccio in one terminal
  • run DRY_RUN=true npm run ci:release in another terminal. Like the release workflow is doing
  • create a package.json file in a local folder then run npm i @elastic/apm-rum-angular --registry=http://localhost:4873
  • Checked that:
    • @elastic/apm-rum-core & @elastic/apm-rum dependencies are installed correctly
    • @elastic/apm-rum-angular has the right version number for them

@github-actions
Copy link
Copy Markdown

🤖 GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@david-luna
Copy link
Copy Markdown
Member Author

The release process changes to much between dry-run and prod modes. I think we should not maintain the dry-run anymore the way it is. Other tools just print a plan of the actions the command is going to take when a dry run flag is passed. IMH I think we should do the same:

  • verify packages build
  • print the plan (actions/commands) to be executed for publishing

@david-luna david-luna closed this Feb 6, 2026
@david-luna david-luna deleted the release-dry-run-locally branch February 6, 2026 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant