Skip to content

fix: handle invalid date objects in jsonify stringify #2851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bartlomieju merged 2 commits into from
Mar 26, 2026
Merged

fix: handle invalid date objects in jsonify stringify #2851

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7779769
fix: Add support for Invalid Date objects in jsonify stringify
dahlia Apr 14, 2025
6135921
Merge remote-tracking branch 'origin/main' into dahlia/main
bartlomieju Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/fresh/src/jsonify/__snapshots__/round_trip_test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@ snapshot[`round trip - URL {\\n href: 'https://fresh.deno.dev/',\\n origin: 'h

snapshot[`round trip - 1990-05-31T00:00:00.000Z 1`] = `'[["Date","1990-05-31T00:00:00.000Z"]]'`;

snapshot[`round trip - Invalid Date 1`] = `'[["Date","Invalid Date"]]'`;

snapshot[`round trip - Map(2) { 1 => null, undefined => -2 } 1`] = `'[["Map",[1,-2,-1,2]],1,-2]'`;

snapshot[`round trip - Set(5) { 1, 2, null, -2, NaN } 1`] = `'[["Set",[1,2,-2,3,-3]],1,2,-2]'`;
Expand Down
1 change: 1 addition & 0 deletions packages/fresh/src/jsonify/round_trip_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ const TESTS = [
new Uint8Array([1, 2, 3]),
new URL("https://fresh.deno.dev"),
new Date("1990-05-31"),
new Date("Invalid Date"),
new Map([[1, null], [undefined, -2]]),
new Set([1, 2, null, -2, NaN]),
[1, , 3],
Expand Down
8 changes: 7 additions & 1 deletion packages/fresh/src/jsonify/stringify.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,13 @@ function serializeInner(
if (value instanceof URL) {
str += `["URL","${value.href}"]`;
} else if (value instanceof Date) {
str += `["Date","${value.toISOString()}"]`;
let iso: string;
try {
iso = value.toISOString();
} catch {
iso = "Invalid Date";
}
str += `["Date","${iso}"]`;
} else if (value instanceof RegExp) {
str += `["RegExp",${JSON.stringify(value.source)}, "${value.flags}"]`;
} else if (value instanceof Uint8Array) {
Expand Down
Loading