fix: handle invalid date objects in jsonify stringify#2851
Merged
bartlomieju merged 2 commits intodenoland:mainfrom Mar 26, 2026
Merged
fix: handle invalid date objects in jsonify stringify#2851bartlomieju merged 2 commits intodenoland:mainfrom
bartlomieju merged 2 commits intodenoland:mainfrom
Conversation
Contributor
Author
|
The tests failed, but apparently it's not related to the changes I made. |
# Conflicts: # packages/fresh/src/jsonify/stringify.ts
bartlomieju
changed the title
Date objects in jsonify stringify
bartlomieju
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Date.toISOString()throws for invalid dates by catching the error and serializing as"Invalid Date"new Date("Invalid Date")serializes to["Date","Invalid Date"]and deserializes back to an invalidDateobjectDateTest plan
deno test -A packages/fresh/src/jsonify/— all 39 tests pass🤖 Generated with Claude Code