[daemon] Remove support for appliances

[jimporter]

This resolves #4120.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.39%. Comparing base (011daaf) to head (bda64bd).
⚠️ Report is 909 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4363      +/-   ##
==========================================
- Coverage   89.70%   89.39%   -0.31%     
==========================================
  Files         260      260              
  Lines       15852    18590    +2738     
==========================================
+ Hits        14219    16617    +2398     
- Misses       1633     1973     +340     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[jimporter]

This test is pretty simple and is mainly just to ensure that we can auto-populate image_hosts. Maybe we could add a few more EXPECT_* calls in here to cover the other members...

[sharder996]

Would you be able to link some documentation referencing the deprecation of Invoke()?

[jimporter]

Would you be able to link some documentation referencing the deprecation of Invoke()?

@sharder996 I don't see anything in the actual docs, but this is the warning I get when using Invoke(some_callable) (with some extra newlines added for readability):

/home/jim/cnc/multipass/tests/mock_process_factory.cpp: In constructor
  ‘multipass::test::MockProcess::MockProcess(std::unique_ptr<multipass::ProcessSpec>&&,
    std::vector<multipass::test::MockProcessFactory::ProcessInfo>&)’:
/home/jim/cnc/multipass/tests/mock_process_factory.cpp:43:49:
  warning: ‘typename std::decay<_Tp>::type testing::Invoke(FunctionImpl&&) [with FunctionImpl =
    multipass::test::MockProcess::MockProcess(std::unique_ptr<multipass::ProcessSpec>&&,
    std::vector<multipass::test::MockProcessFactory::ProcessInfo>&)::<lambda()>;
    typename std::decay<_Tp>::type = multipass::test::MockProcess::MockProcess(
      std::unique_ptr<multipass::ProcessSpec>&&,
      std::vector<multipass::test::MockProcessFactory::ProcessInfo>&)::<lambda()>]’
  is deprecated: Actions can now be implicitly constructed from callables.
  No need to create wrapper objects using Invoke(). [-Wdeprecated-declarations]
   43 |     ON_CALL(*this, start()).WillByDefault(Invoke([this] { emit started(); }));
      |                                           ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /home/jim/cnc/multipass/build/_deps/googletest-src/googlemock/include/gmock/gmock.h:56,
                 from /home/jim/cnc/multipass/tests/common.h:22,
                 from /home/jim/cnc/multipass/tests/mock_process_factory.h:20,
                 from /home/jim/cnc/multipass/tests/mock_process_factory.cpp:18:
/home/jim/cnc/multipass/build/_deps/googletest-src/googlemock/include/gmock/gmock-actions.h:2046:41:
  note: declared here
 2046 | typename std::decay<FunctionImpl>::type Invoke(FunctionImpl&& function_impl) {
      |                                         ^~~~~~

[sharder996]

Ok, thanks for the additional details. Just so there's a breadcrumb trail to justify the Invoke() change.

Otherwise, LGTM!

[levkropp]

LGTM! The only other references to appliances are related to blueprints tests which are going to be removed shortly as well 😀