Remove Codecov, decrease CI web request load, and remove new-PR draft-notice CI job#316
Merged
Remove Codecov, decrease CI web request load, and remove new-PR draft-notice CI job#316
Conversation
bskinn
added
type: maintenance 🔧
|
Hello, and thank you for contributing! This project is configured to run fewer workflows on draft PRs, so if you would like to receive pass/fail feedback from the test suite more quickly, please switch this PR to 'draft' status. You can mark the PR as 'ready' whenever you like, to enable the more extensive set of checks. |
|
I'll summarise github action errors for you when they occur. |
bskinn
changed the title
bskinn
changed the title
Only works on PRs from this repo, not from forks. Kind of defeats the point. Probably a permissions issue.
Rate limiting is a limit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The newest incarnation of Codecov is breaking builds, despite being configured per the instructions on the site.
As the project is small in SLOC and team, Codecov is overweight for what the project needs. Just run
pytest --nonloc --covto evaluate current coverage.CI is set up so that 100% coverage is not a blocker to a regular PR to
main. The job inrelease_test_file_coverage.ymlwill fail at release-prep time if coverage has dropped; I'll handle closing that gap, and not put it on contributors.Also, having
--testall --nonlocin the massive test matrix is exceeding some rate limits, retrieving the inventory files numerous times in parallel. So, we change the test matrix to only--testall, and add a separate, much-smaller-scale--nonlocjob.Also-also, the CI job meant to post a notice on new PRs about lighter CI requirements for draft PRs doesn't work on PRs originating from forks -- permission issues, likely. Disabling it for now.