Skip to content

Skip more characters in test_name_lead_chars for Sphinx 8.2#315

Merged
bskinn merged 5 commits intobskinn:mainfrom
mitya57:sphinx-8.2
May 23, 2025
Merged

Skip more characters in test_name_lead_chars for Sphinx 8.2#315
bskinn merged 5 commits intobskinn:mainfrom
mitya57:sphinx-8.2

Conversation

@mitya57
Copy link
Copy Markdown
Contributor

@mitya57 mitya57 commented May 18, 2025

This PR will (hopefully) make the tests pass with Sphinx 8.2.

See #314 for the related discussion.

@bskinn
Copy link
Copy Markdown
Owner

bskinn commented May 18, 2025

CI failures are partly known, partly new, and something for me to address. Working on it in #316.

@bskinn
Copy link
Copy Markdown
Owner

bskinn commented May 18, 2025

Ok, I've trimmed/reshaped the problematic parts of the CI and merged to main. @mitya57, please merge main into your working branch and we'll see how it goes. (Clicking GitHub's Update branch button should work fine, I think.)

@mitya57
Copy link
Copy Markdown
Contributor Author

mitya57 commented May 19, 2025

Done (I rebased on top of main).

@bskinn bskinn added type: maintenance 🔧 Something administrative needs upkeep pr: needs changelog 📍 area: tests 🩺 Focused on the test suite bump: upkeep 🐞 Changes outside the package itself (x.y.z.w) labels May 20, 2025
@bskinn bskinn added this to the Next Upkeep milestone May 20, 2025
@bskinn
Copy link
Copy Markdown
Owner

bskinn commented May 20, 2025

Ok, @mitya57, please add entries to CHANGELOG.md describing the test change and the fixes/adds I made to tox.ini. I think this will be ready for merge at that point.

@mitya57
Copy link
Copy Markdown
Contributor Author

mitya57 commented May 20, 2025

Done.

@bskinn bskinn merged commit 765cfe1 into bskinn:main May 23, 2025
21 checks passed
@bskinn
Copy link
Copy Markdown
Owner

bskinn commented May 23, 2025

All set, thanks @mitya57!

@mitya57 mitya57 deleted the sphinx-8.2 branch May 23, 2025 06:19
@bskinn
Copy link
Copy Markdown
Owner

bskinn commented May 26, 2025

@mitya57, FYI, this change to the test suite is now live on PyPI as part of v2.3.1.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: tests 🩺 Focused on the test suite bump: upkeep 🐞 Changes outside the package itself (x.y.z.w) pr: merge ready 👍 type: maintenance 🔧 Something administrative needs upkeep

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants