fix(argo-cd): quote VPA updateMode to prevent YAML boolean coercion#3790
Merged
tico24 merged 1 commit intoargoproj:mainfrom Mar 19, 2026
Merged
Conversation
snigdhasambitak
force-pushed
the
fix/vpa-updatemode-quoting
branch
from
500478b to
5297406
Compare
snigdhasambitak
requested review from
jmeridth,
mbevc1,
mkilchhofer,
pdrastil,
tico24 and
yu-croco
as code owners
Member
|
can you re-add the other checklist items and then do them please? |
snigdhasambitak
force-pushed
the
fix/vpa-updatemode-quoting
branch
from
5297406 to
fe95a3c
Compare
tico24
reviewed
Mar 19, 2026
| artifacthub.io/changes: | | ||
| - kind: fixed | ||
| description: Omit runAsUser for dex when deployed on OpenShift | ||
| description: Quote VPA updateMode to prevent YAML boolean coercion of Off to false |
Member
There was a problem hiding this comment.
you need to remove the old entry.
Contributor
Author
There was a problem hiding this comment.
The old changelog entry (Omit runAsUser for dex when deployed on OpenShift) has been replaced
Member
There was a problem hiding this comment.
no it hasn't. you have appended to it.
Contributor
Author
There was a problem hiding this comment.
Fixed.. combined into a single changelog entry
snigdhasambitak
force-pushed
the
fix/vpa-updatemode-quoting
branch
from
fe95a3c to
d64e486
Compare
snigdhasambitak
force-pushed
the
fix/vpa-updatemode-quoting
branch
from
d64e486 to
c8cb50f
Compare
YAML interprets unquoted `Off` as boolean `false`. Add `| quote` filter to ensure updateMode is rendered as a string. Also fix `annnotaions` typo in the annotations key. Fixes argoproj#3789 Signed-off-by: Snigdha Aryakumar <snigdha.sambit.ak@gmail.com>
snigdhasambitak
force-pushed
the
fix/vpa-updatemode-quoting
branch
from
c8cb50f to
eb9923b
Compare
tico24
approved these changes
Mar 19, 2026
jmeridth
approved these changes
Mar 19, 2026
1 task
xavier-re
pushed a commit
to xavier-re/argo-helm-xr
that referenced
this pull request
Apr 8, 2026
…rgoproj#3790) YAML interprets unquoted `Off` as boolean `false`. Add `| quote` filter to ensure updateMode is rendered as a string. Also fix `annnotaions` typo in the annotations key. Fixes argoproj#3789 Signed-off-by: Snigdha Aryakumar <snigdha.sambit.ak@gmail.com> Signed-off-by: Xavier Renaut <xavier.renaut@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
updateModein the VPA template to prevent YAML from interpretingOffas booleanfalseannnotaionstypo (3 n's) toannotationsProblem
charts/argo-cd/templates/argocd-application-controller/vpa.yamlline 26 rendersupdateModewithout quoting:When set to
"Off", Helm outputsupdateMode: Offwhich YAML interprets as booleanfalse. The valid VPA updateMode values are strings:Off,Initial,Recreate,Auto.Fix
Fixes #3789
Checklist