Missile Defense - New Component by BrettMayson · Pull Request #10965 · acemod/ACE3

BrettMayson · 2025-06-17T05:37:07Z

When merged this pull request will:

Alternative to Add - Iron dome for defending against projectiles #10038
Supports multiple systems in a mission
Automatically determine projectile types to intercept (at the cost of customization, maybe could be added)

https://www.youtube.com/watch?v=H-JSDWOMnXY

This meets my needs and if big changes are wanted someone will have to take over. I still didn't use a CBA state machine just because I wanted to do this quick and I don't know them.

Could maybe use some additional customization and functionality (specifying projectile classes to intercept, only fire on projectiles that will hit in a certain area?)

IMPORTANT

If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
Development Guidelines are read, understood and applied.
Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

TheCandianVendingMachine

initial pass, not super thorough. I'm going to close the other PR, I like this more in every way (especially naming given recent events...)

Co-authored-by: Filip Maciejewski <[email protected]> Co-authored-by: PabstMirror <[email protected]>

SpicyBagpipes

I'm daft and couldn't figure out how to PR the branch on GitHub desktop so have a review instead

Co-Authored-By: SpicyBagpipes <[email protected]>

PabstMirror · 2026-05-12T01:59:55Z

+ * Create a missile defense system.
+ *
+ * Arguments:
+ * 0: Sides <ARRAY of SIDEs> - The sides that the missile defense system will engage. If not provided, it will engage all sides.


Suggested change

* 0: Sides <ARRAY of SIDEs> - The sides that the missile defense system will engage. If not provided, it will engage all sides.

* 0: Sides - The sides that the missile defense system will engage. If not provided, it will engage all sides. <ARRAY of SIDEs>

PabstMirror · 2026-05-12T02:00:19Z

+ *
+ * Arguments:
+ * 0: Sides <ARRAY of SIDEs> - The sides that the missile defense system will engage. If not provided, it will engage all sides.
+ * 1: ID <STRING> - Optional, The ID of the missile defense system to create.


Suggested change

* 1: ID <STRING> - Optional, The ID of the missile defense system to create.

* 1: ID - Optional, The ID of the missile defense system to create. <STRING>

PabstMirror · 2026-05-12T02:00:31Z

+ * 1: ID <STRING> - Optional, The ID of the missile defense system to create.
+ *
+ * Return Value:
+ * <STRING> - The ID of the created missile defense system.


Suggested change

* <STRING> - The ID of the created missile defense system.

The ID of the created missile defense system. <STRING>

PabstMirror · 2026-05-12T02:00:41Z

+ * <STRING> - The ID of the created missile defense system.
+ *
+ * Example:
+ * [] call ace_missile_defense_createSystem


Suggested change

* [] call ace_missile_defense_createSystem

* [] call ace_missile_defense_fnc_createSystem

PabstMirror · 2026-05-12T02:00:54Z

+params ["_sides", ["_id", ""]];
+
+if (!isServer) exitWith {
+    ERROR("missile_defense functions only run on server");


Suggested change

ERROR("missile_defense functions only run on server");

ERROR("missile_defense functions only run on server"); "#error"

PabstMirror · 2026-05-12T02:04:56Z

+                if (_angle <= GVAR(launchAcceptableAngle) && _elevation >= GVAR(launchAcceptableElevation)) then {
+                    _launcher setVariable [QGVAR(state), LAUNCH_STATE_COOLDOWN];
+                    _launcher setVariable [QGVAR(lastLaunchTime), CBA_missionTime];
+                    private _turret = [_launcher, (crew _launcher) select 0] call CBA_fnc_turretPath;


Suggested change

private _turret = [_launcher, (crew _launcher) select 0] call CBA_fnc_turretPath;

private _turret = [(crew _launcher) select 0] call CBA_fnc_turretPath;

PabstMirror · 2026-05-12T02:06:02Z

+        TRACE_1("Destroyed projectile using object",_target);
+    };
+    private _near = nearestObjects [_position, [_type], GVAR(destroyRadius)];
+    if (count _near > 0) then {


Suggested change

if (count _near > 0) then {

if (_near isNotEqualTo []) then {

PabstMirror · 2026-05-12T02:08:18Z

+
+GVAR(destroyRadius) = 20;
+
+[QGVAR(destroyProjectile), {


I think we would want this event to be added everywhere (not just preInitClient)
So server will also delete shots and prevent damage being applied

PabstMirror · 2026-05-12T02:12:11Z

+if (_launcher in _launchers) exitWith {
+    ERROR_1("Missile defense launcher '%1' already registered",_launcher);
+};
+


maybe add warning if placed with no crew

Suggested change

if ((crew _launcher) isEqualTo []) then { WARNING_1("no crew for launcher %1",_launcher); };

PabstMirror · 2026-05-12T02:13:56Z

+if (!isNil "_target" && {!isNull _target}) then {
+    private _sides = _system getOrDefault ["sides", []];
+    private _side = _target getVariable [QGVAR(side), side _target];
+    if (_side in _sides) then {


Suggested change

if (_side in _sides) then {

if (_side in _sides || {_sides isEqualTo []}) then {

this would match createSystem's header

PabstMirror · 2026-05-12T02:18:11Z

+                    _launcher setVariable [QGVAR(state), LAUNCH_STATE_COOLDOWN];
+                    _launcher setVariable [QGVAR(lastLaunchTime), CBA_missionTime];
+                    private _turret = [_launcher, (crew _launcher) select 0] call CBA_fnc_turretPath;
+                    [_launcher, _launcher currentWeaponTurret _turret] call BIS_fnc_fire;


this func gave me a lot of trouble
[q1,"ace_missile_manpad_rim116"] call bis_fnc_fire seems to have no effect sometimes
forceWeaponFire seemed to be more reliable but we'd also need to handle locality issues

missile defense rewrite

75d8e5b

BrettMayson requested a review from TheCandianVendingMachine June 17, 2025 05:37

turn off debug mode

34a0c15

BrettMayson commented Jun 17, 2025

View reviewed changes

Comment thread .vscode/settings.json Outdated

some fixes

84c0d67

TheCandianVendingMachine requested changes Jun 17, 2025

View reviewed changes

Comment thread addons/missile_defense/CfgEventHandlers.hpp Outdated

Comment thread addons/missile_defense/XEH_preInit.sqf Outdated

TheCandianVendingMachine mentioned this pull request Jun 17, 2025

Add - Iron dome for defending against projectiles #10038

Closed

PabstMirror reviewed Jun 21, 2025

View reviewed changes

Comment thread addons/missile_defense/CfgEventHandlers.hpp Outdated

Comment thread addons/missile_defense/XEH_preInit.sqf Outdated

Comment thread addons/missile_defense/XEH_preInit.sqf Outdated

Comment thread addons/missile_defense/functions/fnc_systemPFH.sqf Outdated

m1kesk reviewed Jun 29, 2025

View reviewed changes

Comment thread addons/missile_defense/functions/fnc_interceptorPFH.sqf Outdated

BrettMayson added 4 commits September 12, 2025 23:20

cleanup from reviews

ae54093

Merge remote-tracking branch 'upstream/master' into missile_defense

325816b

disable debug

e41fd4c

take angle into account

f7f6513

BrettMayson requested a review from PabstMirror September 13, 2025 06:12

BrettMayson added 8 commits September 13, 2025 03:52

handle visiblity better

c09d13d

handle side better

022192b

more tracing

09f87d0

wip: hoping this fixes mp sync?

98ab0f0

wip: hoping this fixes mp sync?

18f62ff

wip: hoping this fixes mp sync?

2d3d9a1

use nearestObject for client vehicle deletion

abdc3db

fix postInitClient

c189394

veteran29 requested changes Sep 14, 2025

View reviewed changes

PabstMirror reviewed Sep 21, 2025

View reviewed changes

Comment thread addons/missile_defense/XEH_preInit.sqf

Apply suggestions from code review

430804c

Co-authored-by: Filip Maciejewski <[email protected]> Co-authored-by: PabstMirror <[email protected]>

SpicyBagpipes suggested changes Feb 6, 2026

View reviewed changes

Comment thread addons/missile_defense/functions/fnc_createSystem.sqf Outdated

Comment thread addons/missile_defense/functions/fnc_registerTracker.sqf Outdated

Comment thread addons/missile_defense/initSettings.inc.sqf

BrettMayson added 2 commits February 16, 2026 09:28

Merge branch 'master' into missile_defense

0d20315

review comments

df69628

SpicyBagpipes suggested changes Mar 1, 2026

View reviewed changes

Comment thread addons/missile_defense/functions/fnc_interceptorPFH.sqf

Comment thread addons/missile_defense/functions/fnc_interceptorPFH.sqf Outdated

Comment thread addons/missile_defense/functions/fnc_interceptorPFH.sqf Outdated

kjw suggestions

afeba1d

Co-Authored-By: SpicyBagpipes <[email protected]>

BrettMayson requested review from PabstMirror, TheCandianVendingMachine and veteran29 March 20, 2026 20:59

PabstMirror requested changes May 12, 2026

View reviewed changes

PabstMirror reviewed May 12, 2026

View reviewed changes

	* 0: Sides <ARRAY of SIDEs> - The sides that the missile defense system will engage. If not provided, it will engage all sides.
	* 0: Sides - The sides that the missile defense system will engage. If not provided, it will engage all sides. <ARRAY of SIDEs>

	* 1: ID <STRING> - Optional, The ID of the missile defense system to create.
	* 1: ID - Optional, The ID of the missile defense system to create. <STRING>

	* <STRING> - The ID of the created missile defense system.
	The ID of the created missile defense system. <STRING>

	* [] call ace_missile_defense_createSystem
	* [] call ace_missile_defense_fnc_createSystem

	ERROR("missile_defense functions only run on server");
	ERROR("missile_defense functions only run on server"); "#error"

	private _turret = [_launcher, (crew _launcher) select 0] call CBA_fnc_turretPath;
	private _turret = [(crew _launcher) select 0] call CBA_fnc_turretPath;

	if (count _near > 0) then {
	if (_near isNotEqualTo []) then {



	if ((crew _launcher) isEqualTo []) then { WARNING_1("no crew for launcher %1",_launcher); };

	if (_side in _sides) then {
	if (_side in _sides \|\| {_sides isEqualTo []}) then {


		GVAR(destroyRadius) = 20;

		[QGVAR(destroyProjectile), {

Conversation

BrettMayson commented Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

IMPORTANT

Uh oh!

Uh oh!

TheCandianVendingMachine left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SpicyBagpipes left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

BrettMayson commented Jun 17, 2025 •

edited

Loading