Tools - Add VS Code spell checking & recommended extensions#10781
Open
Timi007 wants to merge 3 commits into
Open
Tools - Add VS Code spell checking & recommended extensions#10781Timi007 wants to merge 3 commits into
Timi007 wants to merge 3 commits into
Conversation
rautamiekka
suggested changes
Mar 6, 2025
| { | ||
| "filename": "**/stringtable.xml", | ||
| "includeRegExpList": [ | ||
| "/<English>(.*)<\\/English>.*/", |
Contributor
There was a problem hiding this comment.
Which flavor is this sentence ? I think (.*) should be (.*?) for fewer problems.
Contributor
Author
There was a problem hiding this comment.
I'm assuming it's JS RegExp if the extension is written in TypeScript.
| "/\\s*(\\* Author:).*/", // Ignore author names in header | ||
| "/\\s*authors\\[\\]\\s*=\\s*{(.*)};.*/", // Ignore author names in CfgPatches | ||
| "/\\s*author\\s*=.*/", // Ignore author in config | ||
| "/.*((Amov)|(Ainj)|(Acin)|(Ainv)).+/", // Ignore animation names |
Contributor
There was a problem hiding this comment.
Why have each part in parenthesis ? Also the starting A doesn't need duplicating, I think.
Suggested change
| "/.*((Amov)|(Ainj)|(Acin)|(Ainv)).+/", // Ignore animation names | |
| "/.*A(mov|in[jv]|cin).+/", // Ignore animation names |
Contributor
Author
There was a problem hiding this comment.
It is easier to read. I don't know if I like your edit.
rautamiekka
suggested changes
Mar 7, 2025
Co-authored-by: Jouni Järvinen <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}.