Full implementation of all three JWS serialization shapes by n0900 · Pull Request #419 · a-sit-plus/signum

n0900 · 2026-03-11T15:56:14Z

Implements three new classes JwsCompact, JwsFlattened and JwsGeneral to implement RFC 7515 Section 3.1, 7.2.1 and 7.2.2 respectively.

Removed generic parameter as present in JwsSigned which will be deprecated. Payload can still be serialized into a specific structure at runtime. Serialization stability is now guaranteed by handling all signature related parameters as bytearrays and deserializing into transient properties only.

chatgpt-codex-connector · 2026-03-11T15:56:22Z

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

nodh · 2026-03-12T09:28:17Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 56f6601f79

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

indispensable-josef/src/commonMain/kotlin/at/asitplus/signum/indispensable/josef/JwsCompact.kt

indispensable-josef/src/commonMain/kotlin/at/asitplus/signum/indispensable/josef/Jws.kt

chatgpt-codex-connector · 2026-03-12T12:59:07Z

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

chatgpt-codex-connector · 2026-03-12T13:24:14Z

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

JesusMcCloud

should not be serailiazable. Otherwise, I like the semantics and how it is constructed, so keep the class but get rid of it being serializable

indispensable-josef/src/commonMain/kotlin/at/asitplus/signum/indispensable/josef/JwsCompact.kt

nodh

I like it, some minor remarks

indispensable-josef/src/commonMain/kotlin/at/asitplus/signum/indispensable/josef/JwsSigned.kt

indispensable-josef/src/commonMain/kotlin/at/asitplus/signum/indispensable/josef/JwsCompact.kt

indispensable-josef/src/commonMain/kotlin/at/asitplus/signum/indispensable/josef/Jws.kt

indispensable-josef/src/commonMain/kotlin/at/asitplus/signum/indispensable/josef/JwsCompact.kt

...spensable-josef/src/commonMain/kotlin/at/asitplus/signum/indispensable/josef/JwsFlattened.kt

indispensable-josef/src/commonMain/kotlin/at/asitplus/signum/indispensable/josef/JwsHeader.kt

...e-josef/src/commonTest/kotlin/at/asitplus/signum/indispensable/josef/JwsSerializationTest.kt

chatgpt-codex-connector · 2026-03-16T11:32:35Z

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

chatgpt-codex-connector · 2026-03-16T11:52:30Z

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

nodh · 2026-03-16T11:52:43Z

@codex review please

chatgpt-codex-connector · 2026-03-16T11:55:49Z

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c5087659e1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

indispensable-josef/src/commonMain/kotlin/at/asitplus/signum/indispensable/josef/JwsCompact.kt

chatgpt-codex-connector · 2026-03-16T12:24:18Z

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

chatgpt-codex-connector · 2026-03-16T13:08:06Z

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

JesusMcCloud

Minor API tweak requested

indispensable-josef/src/commonMain/kotlin/at/asitplus/signum/indispensable/josef/JwsCompact.kt

...spensable-josef/src/commonMain/kotlin/at/asitplus/signum/indispensable/josef/JwsFlattened.kt

indispensable-josef/src/commonMain/kotlin/at/asitplus/signum/indispensable/josef/JwsGeneral.kt

chatgpt-codex-connector · 2026-03-19T15:19:48Z

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

chatgpt-codex-connector · 2026-03-19T16:28:04Z

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

chatgpt-codex-connector · 2026-03-19T16:40:01Z

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

chatgpt-codex-connector · 2026-03-19T17:17:02Z

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

nodh · 2026-03-20T09:27:56Z

@codex review please, you can do that!

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 35c72bd98e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-03-20T09:35:25Z

...spensable-josef/src/commonMain/kotlin/at/asitplus/signum/indispensable/josef/JwsFlattened.kt

+    @SerialName(SerialNames.HEADER)
+    val unprotectedHeader: JwsHeader.Part? = null,


Preserve unknown unprotected header parameters

Because header is deserialized into JwsHeader.Part while joseCompliantSerializer has ignoreUnknownKeys = true, any unprotected header parameter that is not modeled in Part is silently discarded. A flattened/general JWS like {"header":{"alg":"RS256","foo":"bar"},...} will therefore lose foo when it is parsed and then re-encoded or converted, even though RFC 7515 allows application-defined header parameters there. The protected side is preserved as raw bytes, so this refactor makes JSON JWS round-tripping asymmetric only for unprotected headers.

Useful? React with 👍 / 👎.

This is true. Private Header Parameters will be supported when the use-case arises.

we should document this fact

...spensable-josef/src/commonMain/kotlin/at/asitplus/signum/indispensable/josef/JwsFlattened.kt

…alization in tact

chatgpt-codex-connector · 2026-03-24T10:27:06Z

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

chatgpt-codex-connector · 2026-03-24T11:58:53Z

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

chatgpt-codex-connector · 2026-03-24T13:33:04Z

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

n0900 requested review from JesusMcCloud, iaik-jheher and nodh March 11, 2026 15:56

n0900 self-assigned this Mar 11, 2026

n0900 mentioned this pull request Mar 11, 2026

General JWS JSON #414

Closed

chatgpt-codex-connector bot reviewed Mar 12, 2026

View reviewed changes

indispensable-josef/src/commonMain/kotlin/at/asitplus/signum/indispensable/josef/JwsCompact.kt Show resolved Hide resolved

indispensable-josef/src/commonMain/kotlin/at/asitplus/signum/indispensable/josef/Jws.kt Show resolved Hide resolved

JesusMcCloud requested changes Mar 12, 2026

View reviewed changes

indispensable-josef/src/commonMain/kotlin/at/asitplus/signum/indispensable/josef/JwsCompact.kt Outdated Show resolved Hide resolved

indispensable-josef/src/commonMain/kotlin/at/asitplus/signum/indispensable/josef/JwsCompact.kt Show resolved Hide resolved

nodh requested changes Mar 13, 2026

View reviewed changes

chatgpt-codex-connector bot reviewed Mar 16, 2026

View reviewed changes

indispensable-josef/src/commonMain/kotlin/at/asitplus/signum/indispensable/josef/JwsCompact.kt Show resolved Hide resolved

n0900 force-pushed the feature/refactorJWS branch from 08c30cb to 384d6ff Compare March 16, 2026 12:24

n0900 requested review from JesusMcCloud and nodh March 16, 2026 12:24

JesusMcCloud requested changes Mar 16, 2026

View reviewed changes

n0900 force-pushed the feature/refactorJWS branch from b5f443d to 35c72bd Compare March 19, 2026 17:16

chatgpt-codex-connector bot reviewed Mar 20, 2026

View reviewed changes

n0900 added 22 commits March 24, 2026 11:20

Parse JwsHeader immediatly

a36d5e9

Stricter invoke JwsCompact

e07a98f

Strict parse SignatureElement JwsHeader

f1fca9d

Add replaceWith

0ba8bf7

More eager parsing

c85c30b

Remove registered Serializer from JwsCompact leaving intentional seri…

ac0a66e

…alization in tact

Use SerialNames

acc89b9

Replace exceptionOrNull with shouldBeFailure

3f7fa2b

Add JwsHeader Documentation

bb027eb

Add Jws Documentation

c2b78bc

Add CHANGELOG entry

a18dbdc

Add shape names to SerialNames

871bb82

Remove deprectated .deserialize

d9c2c45

Remove deprectated .serialize

01a3118

Only parse valid base64url strings

4477c73

Test JWS serializer more thoroughly

c25f451

Usability improvements

3924235

Convenience function

807de33

Make constructors internal

106c58b

Correctly de-/encode empty protected header

32468e1

Add SerialNames Object

350c80e

Make constructors internal

bbf285a

n0900 force-pushed the feature/refactorJWS branch from b17815f to bbf285a Compare March 24, 2026 10:26

Add clarifying comments about bytearray encoding

2cb6fc5

n0900 requested a review from JesusMcCloud March 24, 2026 11:58

Add clarifying comments about private header parameters

6468ecb

n0900 mentioned this pull request Mar 24, 2026

Migrate from JwsSigned to new JwsCompact a-sit-plus/vck#540

Draft

		@SerialName(SerialNames.HEADER)
		val unprotectedHeader: JwsHeader.Part? = null,

Conversation

n0900 commented Mar 11, 2026

Uh oh!

chatgpt-codex-connector bot commented Mar 11, 2026

Uh oh!

nodh commented Mar 12, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector bot commented Mar 12, 2026

Uh oh!

chatgpt-codex-connector bot commented Mar 12, 2026

Uh oh!

JesusMcCloud left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

nodh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector bot commented Mar 16, 2026

Uh oh!

chatgpt-codex-connector bot commented Mar 16, 2026

Uh oh!

nodh commented Mar 16, 2026

Uh oh!

chatgpt-codex-connector bot commented Mar 16, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector bot commented Mar 16, 2026

Uh oh!

chatgpt-codex-connector bot commented Mar 16, 2026

Uh oh!

JesusMcCloud left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector bot commented Mar 19, 2026

Uh oh!

chatgpt-codex-connector bot commented Mar 19, 2026

Uh oh!

chatgpt-codex-connector bot commented Mar 19, 2026

Uh oh!

chatgpt-codex-connector bot commented Mar 19, 2026

Uh oh!

nodh commented Mar 20, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

n0900 Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

JesusMcCloud Mar 24, 2026

Choose a reason for hiding this comment