Skip to content

Migrate from JwsSigned to new JwsCompact#540

Draft
n0900 wants to merge 17 commits intodevelopfrom
feature/jwsCompactMigration2
Draft

Migrate from JwsSigned to new JwsCompact#540
n0900 wants to merge 17 commits intodevelopfrom
feature/jwsCompactMigration2

Conversation

@n0900
Copy link
Copy Markdown
Collaborator

@n0900 n0900 commented Mar 24, 2026

Using JwsCompactTyped not much actually changed except for that it now works better under the hood.
JwsCompactTyped is probably a candidate to move to signum. Dependent on Signum#419. More optimizations using stronger JwsCompact/JwsCompactTyped typing instead of String and new serialization paths are likely possible for many classes but mostly out of scope for this PR because it's already quite huge.

The constructor of JwsCompactTyped cannot be made internal because we need the invoke operators to be inline so that we can infer the payload type on the fly.

I know its conditional on the signum release schedule but as soon as possible please review and merge because this touches nearly every file and merge-conflicts will be horrendous.

@n0900 n0900 requested review from JesusMcCloud and nodh March 24, 2026 18:22
@n0900 n0900 self-assigned this Mar 24, 2026
@n0900 n0900 force-pushed the feature/jwsCompactMigration2 branch from 19ba2e4 to 298004b Compare March 30, 2026 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant