Draft
Conversation
19ba2e4 to
298004b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
JwsCompactTypednot much actually changed except for that it now works better under the hood.JwsCompactTypedis probably a candidate to move to signum. Dependent on Signum#419. More optimizations using strongerJwsCompact/JwsCompactTypedtyping instead ofStringand new serialization paths are likely possible for many classes but mostly out of scope for this PR because it's already quite huge.The constructor of
JwsCompactTypedcannot be made internal because we need the invoke operators to be inline so that we can infer the payload type on the fly.I know its conditional on the signum release schedule but as soon as possible please review and merge because this touches nearly every file and merge-conflicts will be horrendous.