Skip to content

Adapt PAGXView to the new tgfx Window and Surface interface. #3353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shlzxjp merged 3 commits into from
Mar 31, 2026
Merged

Adapt PAGXView to the new tgfx Window and Surface interface. #3353

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8c94142
Adapt PAGXView to the new tgfx Window and Surface interface.
OnionsYu Mar 31, 2026
104699a
Cache the Surface object in PAGXView to avoid recreating it every frame.
OnionsYu Mar 31, 2026
240128a
Reset the cached surface before recreating it on window resize.
OnionsYu Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions playground/src/PAGXView.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,13 +162,12 @@ void PAGXView::updateSize() {
if (window == nullptr) {
return;
}
window->invalidSize();
auto device = window->getDevice();
auto context = device->lockContext();
if (context == nullptr) {
return;
Comment thread
OnionsYu marked this conversation as resolved.
}
auto surface = window->getSurface(context);
surface = tgfx::Surface::MakeFrom(context, window);
if (surface == nullptr) {
device->unlock();
return;
Expand Down Expand Up @@ -244,7 +243,9 @@ void PAGXView::draw() {
if (context == nullptr) {
return;
}
auto surface = window->getSurface(context);
if (surface == nullptr) {
surface = tgfx::Surface::MakeFrom(context, window);
}
if (surface == nullptr) {
device->unlock();
return;
Expand All @@ -271,13 +272,11 @@ void PAGXView::draw() {
presentImmediately = false;
if (recording) {
context->submit(std::move(recording));
window->present(context);
}
} else {
std::swap(lastRecording, recording);
if (recording) {
context->submit(std::move(recording));
window->present(context);
}
}
device->unlock();
Expand Down
2 changes: 2 additions & 0 deletions playground/src/PAGXView.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
#include "LayerBuilder.h"
#include "TextLayout.h"
#include "pagx/PAGXDocument.h"
#include "tgfx/core/Surface.h"
#include "tgfx/gpu/Recording.h"
#include "tgfx/gpu/opengl/webgl/WebGLWindow.h"
#include "GridBackground.h"
Expand Down Expand Up @@ -69,6 +70,7 @@ class PAGXView {

std::string canvasID = {};
std::shared_ptr<tgfx::Window> window = nullptr;
std::shared_ptr<tgfx::Surface> surface = nullptr;
tgfx::DisplayList displayList = {};
std::shared_ptr<tgfx::Layer> contentLayer = nullptr;
std::unique_ptr<tgfx::Recording> lastRecording = nullptr;
Expand Down
Loading