Skip to content

Adapt PAGXView to the new tgfx Window and Surface interface.#3353

Merged
shlzxjp merged 3 commits intoTencent:mainfrom
OnionsYu:fix/onionsyu_pagx_viewer
Mar 31, 2026
Merged

Adapt PAGXView to the new tgfx Window and Surface interface.#3353
shlzxjp merged 3 commits intoTencent:mainfrom
OnionsYu:fix/onionsyu_pagx_viewer

Conversation

@OnionsYu
Copy link
Copy Markdown
Contributor

适配 PAGXView 到 tgfx 新的 Window 和 Surface 接口。主要变更:

  • 使用 tgfx::Surface::MakeFrom(context, window) 替代 window->getSurface(context) 创建 Surface
  • 移除 window->invalidSize() 和 window->present(context) 调用,适配新接口不再需要这些方法

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.62%. Comparing base (c9ac8e3) to head (104699a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3353   +/-   ##
=======================================
  Coverage   75.61%   75.62%           
=======================================
  Files         510      510           
  Lines       35435    35435           
  Branches    11283    11283           
=======================================
+ Hits        26795    26797    +2     
- Misses       6352     6353    +1     
+ Partials     2288     2285    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@OnionsYu OnionsYu force-pushed the fix/onionsyu_pagx_viewer branch from 84eecad to 240128a Compare March 31, 2026 11:56
@OnionsYu OnionsYu requested review from Hparty and shlzxjp March 31, 2026 12:09
@shlzxjp shlzxjp merged commit d6ce106 into Tencent:main Mar 31, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants