eden: init at 0.1.1

[marcin-serwin]

It's been nearly 2 years since Yuzu was dropped from nixpkgs and I think that the dust has settled a bit. The most active forks seem to be Citron and Eden, this PR packages the latter.

Resurrects: #406630
Alternative(?) to: #482846

Things done

• Built on platform:
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• Tested, as applicable:
  • NixOS tests in nixos/tests.
  • Package tests at passthru.tests.
  • Tests in lib/tests or pkgs/test for functions and "core" functionality.
• Ran nixpkgs-review on this PR. See nixpkgs-review usage.
• Tested basic functionality of all binary files, usually in ./result/bin/.
• Nixpkgs Release Notes
  • Package update: when the change is major or breaking.
• NixOS Release Notes
  • Module addition: when adding a new NixOS module.
  • Module update: when the change is significant.
• Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

[winterqt]

Hard defer to @NixOS/nixpkgs-core.

[samemrecebi]

Dynamic and oaknut at least in my understanding is used for arm devices (at least they are in citron) so it might be possible to get the package running for darwin or linux arm devices.

[K900]

DMCA wise I think we're OK, given AFAICT the forks have removed the offending code, diff looks OK, will defer to nixpkgs-core as a matter of policy.

[marcin-serwin]

Dynamic and oaknut at least in my understanding is used for arm devices

Dynarmic is always necessary because it's used to emulate Switch CPU

it might be possible to get the package running for darwin or linux arm devices.

I've actually built it on aarch64-linux but it segfaults when trying to launch anything. Upstream publishes experimental macOS builds so it's probably possible if someone is interested.

[manuelVo]

Well that's a coincidence; I've spent the last few days building that same package too. I'm just leaving my two cents on what I'd have done differently. Feel free to implement or ignore my suggestions as you see fit :)

[manuelVo]

Eden and dynarmic have a cmake flag to enable LTO; I suppose enabling that would be good for a rather performance critical emulator. At least this NUR-Package claims it's worth it: https://github.com/nix-community/nur-combined/blob/main/repos/kira-bruneau/pkgs/by-name/ed/eden/package.nix#L136

[marcin-serwin]

This comment was probably carried over from the original yuzu recipe:

nixpkgs/pkgs/applications/emulators/yuzu/mainline.nix

Lines 104 to 105 in 1cba047

	# actually has a noticeable performance impact
	"-DYUZU_ENABLE_LTO=ON"

I've removed it since it was slightly discouraged by the current upstream, see https://git.eden-emu.dev/eden-emu/eden/src/tag/v0.1.0/docs/Options.md#options. I'm fine with enabling it if someone checks that it's still relevant.

[nyabinary]

Well it does say not recommended on Windows and that UNIX should use thin, is there a way to use thin?

[marcin-serwin]

The flag was refactored and the upstream CI now builds with LTO both on linux and windows so I will enable it once 0.2.0 is released.

[alyssais]

No objections from the core team; see #482846 (comment).

[pbsbot]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 485097
Commit: 195890227e3d5508e7108c1d235cce7b7c470a4c

---

x86_64-linux

✅ 6 packages built:

• azahar
• dynarmic
• eden
• mcl-cpp-utility-lib
• oaknut
• sirit

[marcin-serwin]

Since opening this PR two relevant things happened:

• Nintendo once again issued DMCA takedown on existing emulators - https://wccftech.com/nintendo-once-again-brings-dmca-hammer-down-switch-emulators/
• Citron emulator has been discontinued citing previous Eden drama - https://www.reddit.com/r/Citron/comments/1r66in9/the_future_of_citron/

In my opinion, packaging Eden is still OK but posting for visibility in case you want to reconsider your approvals.

Approved by core