eden: General comments

[crueter]

Pinging @marcin-serwin.

1. aarch64-disable-fastmem.patch is not needed, this was a red herring. The actual issue is fastmem isn't supported with 16KB page sizes on Asahi Linux.
2. These two are unnecessary as they default to off already:

    (lib.cmakeBool "YUZU_USE_EXTERNAL_SDL2" false)
    (lib.cmakeBool "YUZU_USE_BUNDLED_FFMPEG" false)

3. https://github.com/NixOS/nixpkgs/blob/master/pkgs/by-name/ed/eden/package.nix#L57-L89 - any reason not to use the premade archive?
4. YUZU_USE_QT_MULTIMEDIA is not functional for Qt 6 and we will eventually remove it upstream

[crueter]

Not PRing because I don't have a Nix system, nor am I the final decision maker for any package other than on Gentoo.

[marcin-serwin]

Thanks for the review, should I ping you in future PRs touching the recipe?

1. I am personally using it on Asahi Linux. I'm guessing that the majority of people using it from nixpkgs do so as well since there aren't many Linux friendly ARM consumer machines with GPUs that are powerful enough. The patch only changes the default so it can still be enabled if somebody is running with 4KB pages.
2. Noted, I'll drop it with 0.2.0 update.
3. Not really, just the default "build as much as possible from source" preference.
4. (See 2.)

[crueter]

Okay, fair enough. We will eventually add 16KB detection to automatically disable fastmem/NCE, but that patch is good enough (TM) for now. Do ping me on future PRs as well

[marcin-serwin]

BTW, could I ask you what's your preference on enabling LTO? There was some discussion on it in the init PR #485097 (comment)

[crueter]

Oops, I saw that but forgot to respond x)

As in our configure script, Windows is the only platform that doesn't play well with LTO. Linux and macOS both work fine with it, though it comes at the cost of extra linking time.

Enabling it unconditionally here is totally okay (looks like you caught that I changed it to just ENABLE_LTO as well, for 0.2.0+)

[crueter]

Yes, through sysconf(_SC_PAGESIZE). A build flag/compile-time detection wouldn't work anyways since our AppImages are designed to be universal (sans whatever's going on in Steam Deck land).

[crueter]

YUZU_USE_QT_MULTIMEDIA is not functional for Qt 6 and we will eventually remove it upstream

Someone opened up a PR to bring it up for Qt 6: https://git.eden-emu.dev/eden-emu/eden/pulls/3630

It probably will not reach 0.2.0. I think you can just keep it for now since it's likely to make it into the next release