Skip to content

gnomeExtensions.system-monitor: fix order for collisions#461619

Merged
jtojnar merged 1 commit into
NixOS:masterfrom
nekowinston:gnomeExtensions-system-monitor/fix-order
Nov 16, 2025
Merged

gnomeExtensions.system-monitor: fix order for collisions#461619
jtojnar merged 1 commit into
NixOS:masterfrom
nekowinston:gnomeExtensions-system-monitor/fix-order

Conversation

@nekowinston
Copy link
Copy Markdown
Member

@nekowinston nekowinston commented Nov 14, 2025

#461080 changed my pkgs.gnomeExtensions.system-monitor from https://extensions.gnome.org/extension/6807/system-monitor/ -> https://extensions.gnome.org/extension/8272/system-monitor/, which doesn't indicate support for GNOME 49 yet.
This PR fixes the order and adds a new name for the other collision.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci Bot requested a review from jtojnar November 14, 2025 16:15
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 6.topic: GNOME GNOME desktop environment and its underlying platform labels Nov 14, 2025
@nekowinston

This comment was marked as outdated.

@nekowinston nekowinston force-pushed the gnomeExtensions-system-monitor/fix-order branch from df3a4fa to 44d11b3 Compare November 14, 2025 17:51
@nekowinston
Copy link
Copy Markdown
Member Author

Looks like GIRepository.Repository is used in a bunch of places, and AFAICT Repository.dup_default() is the new way of accessing it: https://gjs-docs.gnome.org/girepository30~3.0/girepository.repository#function-dup_default

@nekowinston nekowinston force-pushed the gnomeExtensions-system-monitor/fix-order branch from 44d11b3 to 9968bd5 Compare November 15, 2025 17:43
@jtojnar jtojnar added this pull request to the merge queue Nov 16, 2025
Merged via the queue into NixOS:master with commit bddebbc Nov 16, 2025
27 of 30 checks passed
@nekowinston nekowinston deleted the gnomeExtensions-system-monitor/fix-order branch November 16, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants