gnomeExtensions: GIRepository fixes

[nekowinston]

gnomeExtensions.system-monitor is separately fixed here: #461619
This applies the patch changes to the other extensions.

I tried all the extensions, drop-down-terminal is still broken, showing

SyntaxError: import declarations may only appear at top level of a module @ resource:///org/gnome/Shell/Extensions/js/misc/extensionUtils.js:4:1

Stack trace:
  @file:///etc/profiles/per-user/winston/share/gnome-shell/extensions/[email protected]/prefs.js:27:12
  _init/GLib.MainLoop.prototype.runAsync/</<@resource:///org/gnome/gjs/modules/core/overrides/GLib.js:263:34

Looks like it's been broken for a while now: https://github.com/zzrough/gs-extensions-drop-down-terminal/issues

Things done

• Built on platform:
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• Tested, as applicable:
  • NixOS tests in nixos/tests.
  • Package tests at passthru.tests.
  • Tests in lib/tests or pkgs/test for functions and "core" functionality.
• Ran nixpkgs-review on this PR. See nixpkgs-review usage.
• Tested basic functionality of all binary files, usually in ./result/bin/.
• Nixpkgs Release Notes
  • Package update: when the change is major or breaking.
• NixOS Release Notes
  • Module addition: when adding a new NixOS module.
  • Module update: when the change is significant.
• Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

---

Add a 👍 reaction to pull requests you find important.

[nekowinston]

dropped arcmenu as this is now covered here: #461911

[niklaskorz]

Tested gsconnect, working correctly

[doronbehar]

Thanks for taking care of this! How did you figure out this is needed? The extensions didn't work without dup_default()?

[nekowinston]

Thanks for taking care of this! How did you figure out this is needed? The extensions didn't work without dup_default()?

I ran into errors like this:
and https://gjs-docs.gnome.org/girepository30~3.0/girepository.repository#function-dup_default mentions that it's new for 2.86

Regarding the explicit version, one extension gave me trouble without it being specified, but I haven't noted down which one, I'll see if its needed for the others. Sorry, pretty bad with multitasking a bunch of similar changes 😅

[niklaskorz]

Thanks for taking care of this! How did you figure out this is needed? The extensions didn't work without dup_default()?

This was prompted by these upstream PRs:

• https://gitlab.gnome.org/GNOME/glib/-/merge_requests/3856 (turning gi_repository_prepend_search_path into a method requiring an instance of GIRepository)
• https://gitlab.gnome.org/GNOME/glib/-/merge_requests/4630 (introducing dup_default)

[nekowinston]

Rebuilt my system with this & #461619 merged, everything's still looking good on my end. Not sure what initially got me to explicitly add the version, didn't seem to be necessary.

[doronbehar]

I made a few slight changes that it was too hard for me to explain them in words.

[SamLukeYes]

Todo.txt extension is still broken after applying this change

[doronbehar]

This PR hasn't touched todo.txt extension. From skimming over:

• https://gitlab.com/todo.txt-gnome-shell-extension/todo-txt-gnome-shell-extension/-/issues
• https://gitlab.com/todo.txt-gnome-shell-extension/todo-txt-gnome-shell-extension/-/commits/master?ref_type=heads

It seems like upstream should change this in their code.

[SamLukeYes]

Sorry, my bad. I forgot that I overrided gnomeExtensions.todotxt according to #350152. Just dropped the override and the extension works as expected.