Skip to content

[24.11] treewide: fix whitespace according to editorconfig#407058

Merged
Mic92 merged 1 commit into
NixOS:release-24.11from
Mic92:whitespace
May 14, 2025
Merged

[24.11] treewide: fix whitespace according to editorconfig#407058
Mic92 merged 1 commit into
NixOS:release-24.11from
Mic92:whitespace

Conversation

@Mic92
Copy link
Copy Markdown
Member

@Mic92 Mic92 commented May 14, 2025

Things done

To fix: #405811 (comment)

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions Bot added 6.topic: kernel The Linux kernel 6.topic: cuda Parallel computing platform and API 4.workflow: backport This targets a stable branch labels May 14, 2025
@nix-owners nix-owners Bot requested a review from philiptaron May 14, 2025 15:36
Comment on lines 1204 to 1205
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about this one. Is this auto-generated? Might need a custom .editorconfig file instead.

@github-actions github-actions Bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. labels May 14, 2025
@wolfgangwalther
Copy link
Copy Markdown
Contributor

Same for the rebuilds - whichever package is causing that, maybe we should just add an editorconfig file for that to silence the warnings here.

@github-actions github-actions Bot removed the 6.topic: kernel The Linux kernel label May 14, 2025
@Mic92
Copy link
Copy Markdown
Member Author

Mic92 commented May 14, 2025

Same for the rebuilds - whichever package is causing that, maybe we should just add an editorconfig file for that to silence the warnings here.

Done.

Comment thread pkgs/development/cuda-modules/cuda/manifests/redistrib_12.4.0.json
@nix-owners nix-owners Bot requested a review from zowoq May 14, 2025 15:49
@github-actions github-actions Bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. and removed 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. labels May 14, 2025
@Mic92
Copy link
Copy Markdown
Member Author

Mic92 commented May 14, 2025

Let's get this merged to fixup CI.

@Mic92 Mic92 merged commit c4a5fd9 into NixOS:release-24.11 May 14, 2025
17 of 21 checks passed
@github-project-automation github-project-automation Bot moved this from New to ✅ Done in CUDA Team May 14, 2025
@Mic92 Mic92 deleted the whitespace branch May 14, 2025 16:38
@wolfgangwalther
Copy link
Copy Markdown
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4.workflow: backport This targets a stable branch 6.topic: cuda Parallel computing platform and API 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants