[24.11] workflows/{editorconfig,keep-sorted}: drop and move to treefmt#405811
Merged
wolfgangwalther merged 2 commits intoMay 10, 2025
Merged
Conversation
We already have treefmt running for nixfmt, so it's easy to just add another formatter to it. This gives a much better UX, because all formatting errors are reported through the same channel. It also saves us one CI job, which takes most of the time to just set up the machine, clone the repo and download Nix - while doing a minimum of actual work. Total execution time for treefmt is ~10% slower: - 38s only nixfmt - 43s nixfmt + editorconfig-checker (cherry picked from commit ba4fe10)
Same reasoning as the commit before, but keep-sorted has even less overhead than editorconfig-checker. Benchmark has it at 1 second per run. (cherry picked from commit 1cb7a38)
github-actions
Bot
added
6.topic: continuous integration
nix-owners
Bot
requested review from
LeSuisse,
Mic92,
infinisil,
mweinelt,
philiptaron,
risicle and
zowoq
github-actions
Bot
added
10.rebuild-darwin: 0
Member
|
Pretty sure this broke formatting CI on 24.11, see all of the red in https://github.com/NixOS/nixpkgs/pulls?q=is%3Apr+base%3Arelease-24.11. |
Contributor
Author
|
I think it was #406681, but yes. Some files on release-24.11 are still not valid for editorconfig, apparently. I have it on my list to fix for today, but still busy with other stuff. Feel free to fix the offending files :) |
13 tasks
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #405684.
Had a conflict in the OWNERS file, otherwise applied cleanly.
Things done
Add a 👍 reaction to pull requests you find important.