Skip to content

music-assistant: 2.5.0 -> 2.5.2#405770

Merged
mweinelt merged 4 commits intoNixOS:masterfrom
mweinelt:music-assistant-2.5.2
May 12, 2025
Merged

music-assistant: 2.5.0 -> 2.5.2#405770
mweinelt merged 4 commits intoNixOS:masterfrom
mweinelt:music-assistant-2.5.2

Conversation

@mweinelt
Copy link
Copy Markdown
Member

@mweinelt mweinelt commented May 10, 2025

https://github.com/music-assistant/server/releases/tag/2.5.1
https://github.com/music-assistant/server/releases/tag/2.5.2
https://github.com/pkkid/python-plexapi/releases/tag/4.17.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions Bot added the 6.topic: python Python is a high-level, general-purpose programming language. label May 10, 2025
@mweinelt
Copy link
Copy Markdown
Member Author

The nixos test fails on aarch64-linux.

Traceback (most recent call last):
  File "/nix/store/8dzxyl9f33i5kfn56akd54jkizr4rpdl-python3.12-aiorun-2025.1.1/lib/python3.12/site-packages/aiorun/__init__.py", line 223, in new_coro
    await coro
  File "/nix/store/wzfvpa7yk0iv8hr1nqysdzx7y4pwbwhp-music-assistant-2.5.2/lib/python3.12/site-packages/music_assistant/__main__.py", line 214, in start_mass
    await mass.start()
  File "/nix/store/wzfvpa7yk0iv8hr1nqysdzx7y4pwbwhp-music-assistant-2.5.2/lib/python3.12/site-packages/music_assistant/mass.py", line 138, in start
    self.aiozc = AsyncZeroconf(ip_version=IPVersion.V4Only, interfaces=InterfaceChoice.Default)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/8xcqa1507mb9r3ccww42ni6zwiy49a86-python3.12-zeroconf-0.147.0/lib/python3.12/site-packages/zeroconf/asyncio.py", line 171, in __init__
    self.zeroconf = zc or Zeroconf(
                          ^^^^^^^^^
  File "/nix/store/8xcqa1507mb9r3ccww42ni6zwiy49a86-python3.12-zeroconf-0.147.0/lib/python3.12/site-packages/zeroconf/_core.py", line 181, in __init__
    listen_socket, respond_sockets = create_sockets(interfaces, unicast, ip_version, apple_p2p=apple_p2p)
                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/8xcqa1507mb9r3ccww42ni6zwiy49a86-python3.12-zeroconf-0.147.0/lib/python3.12/site-packages/zeroconf/_utils/net.py", line 459, in create_sockets
    add_multicast_member(cast(socket.socket, listen_socket), interface)
  File "/nix/store/8xcqa1507mb9r3ccww42ni6zwiy49a86-python3.12-zeroconf-0.147.0/lib/python3.12/site-packages/zeroconf/_utils/net.py", line 350, in add_multicast_member
    listen_socket.setsockopt(socket.IPPROTO_IP, socket.IP_ADD_MEMBERSHIP, _value)
OSError: [Errno 19] No such device
2025-05-10 03:20:32.665 INFO (MainThread) [aiorun] Entering shutdown phase.
2025-05-10 03:20:32.665 INFO (MainThread) [aiorun] Executing provided shutdown_callback.
2025-05-10 03:20:32.665 INFO (MainThread) [root] shutdown requested!
2025-05-10 03:20:32.666 INFO (MainThread) [music_assistant] Stop called, cleaning up...
2025-05-10 03:20:32.666 INFO (MainThread) [aiorun] Waiting for executor shutdown.
2025-05-10 03:20:32.666 INFO (MainThread) [aiorun] Shutting down async generators
2025-05-10 03:20:32.666 INFO (MainThread) [aiorun] Closing the loop.
2025-05-10 03:20:32.667 INFO (MainThread) [aiorun] Leaving. Bye!
2025-05-10 03:20:32.667 INFO (MainThread) [aiorun] Reraising unhandled exception
2025-05-10 03:20:32.667 ERROR (MainThread) [root] Uncaught exception
Traceback (most recent call last):
  File "/nix/store/wzfvpa7yk0iv8hr1nqysdzx7y4pwbwhp-music-assistant-2.5.2/bin/.mass-wrapped", line 9, in <module>
    sys.exit(main())
             ^^^^^^
  File "/nix/store/wzfvpa7yk0iv8hr1nqysdzx7y4pwbwhp-music-assistant-2.5.2/lib/python3.12/site-packages/music_assistant/__main__.py", line 220, in main
    run(
  File "/nix/store/8dzxyl9f33i5kfn56akd54jkizr4rpdl-python3.12-aiorun-2025.1.1/lib/python3.12/site-packages/aiorun/__init__.py", line 374, in run
    raise pending_exception_to_raise
  File "/nix/store/8dzxyl9f33i5kfn56akd54jkizr4rpdl-python3.12-aiorun-2025.1.1/lib/python3.12/site-packages/aiorun/__init__.py", line 276, in run
    shutdown_callback(loop)
  File "/nix/store/wzfvpa7yk0iv8hr1nqysdzx7y4pwbwhp-music-assistant-2.5.2/lib/python3.12/site-packages/music_assistant/__main__.py", line 205, in on_shutdown
    loop.run_until_complete(mass.stop())
  File "/nix/store/gbml27jdc722w5srjw6mw28v08wi0xbf-python3-3.12.10/lib/python3.12/asyncio/base_events.py", line 691, in run_until_complete
    return future.result()
           ^^^^^^^^^^^^^^^
  File "/nix/store/wzfvpa7yk0iv8hr1nqysdzx7y4pwbwhp-music-assistant-2.5.2/lib/python3.12/site-packages/music_assistant/mass.py", line 205, in stop
    await self.streams.close()
          ^^^^^^^^^^^^
AttributeError: 'MusicAssistant' object has no attribute 'streams'

@github-actions github-actions Bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 10, 2025
@mweinelt mweinelt force-pushed the music-assistant-2.5.2 branch from b589072 to 8ea079b Compare May 12, 2025 22:55
@github-actions github-actions Bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. and removed 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 12, 2025
@mweinelt mweinelt merged commit 0b489d3 into NixOS:master May 12, 2025
23 of 27 checks passed
@mweinelt mweinelt deleted the music-assistant-2.5.2 branch May 12, 2025 23:05
@wegank wegank mentioned this pull request Jun 18, 2025
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python Python is a high-level, general-purpose programming language. 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant