Skip to content

music-assistant: 2.5.0 -> 2.5.1#397893

Closed
autrimpo wants to merge 2 commits intoNixOS:masterfrom
autrimpo:music-assistant-2.5.1
Closed

music-assistant: 2.5.0 -> 2.5.1#397893
autrimpo wants to merge 2 commits intoNixOS:masterfrom
autrimpo:music-assistant-2.5.1

Conversation

@autrimpo
Copy link
Copy Markdown
Contributor

@autrimpo autrimpo commented Apr 11, 2025 •
edited
Loading

Changelog: https://github.com/music-assistant/server/releases/tag/2.5.1

Marking this as draft, because the NixOS test broke. Probably related to music-assistant/server#2100
NixOS test is now fixed.

machine # curl: (7) Failed to connect to localhost port 8095 after 20 ms: Could not connect to server
machine # [    9.601227] mass[696]: 2025-04-11 08:51:54.674 ERROR (MainThread) [music_assistant] Error doing task: Task exception was never retrieved
machine # [    9.603200] mass[696]: Traceback (most recent call last):
machine # [    9.603943] mass[696]:   File "/nix/store/5qhn8garnkwprrv80hql9l59amqikfxf-python3.12-aiorun-2025.1.1/lib/python3.12/site-packages/aiorun/__init__.py", line 223, in new_coro
machine # [    9.606325] mass[696]:     await coro
machine # [    9.606905] mass[696]:   File "/nix/store/623yh2lx5y8255fhaj6i4vnanhdkmzc7-music-assistant-2.5.1/lib/python3.12/site-packages/music_assistant/__main__.py", line 214, in start_mass
machine # [    9.609174] mass[696]:     await mass.start()
machine # [    9.609994] mass[696]:   File "/nix/store/623yh2lx5y8255fhaj6i4vnanhdkmzc7-music-assistant-2.5.1/lib/python3.12/site-packages/music_assistant/mass.py", line 138, in start
machine # [    9.611972] mass[696]:     self.aiozc = AsyncZeroconf(ip_version=IPVersion.V4Only, interfaces=InterfaceChoice.Default)
machine # [    9.613432] mass[696]:                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
machine # [    9.614843] mass[696]:   File "/nix/store/yv2wywvmyrs5xx3lk54p999g1j3w1iyi-python3.12-zeroconf-0.145.1/lib/python3.12/site-packages/zeroconf/asyncio.py", line 171, in __init__
machine # [    9.617516] mass[696]:     self.zeroconf = zc or Zeroconf(
machine # [    9.619147] mass[696]:                           ^^^^^^^^^
machine # [    9.619961] mass[696]:   File "/nix/store/yv2wywvmyrs5xx3lk54p999g1j3w1iyi-python3.12-zeroconf-0.145.1/lib/python3.12/site-packages/zeroconf/_core.py", line 181, in __init__
machine # [    9.622096] mass[696]:     listen_socket, respond_sockets = create_sockets(interfaces, unicast, ip_version, apple_p2p=apple_p2p)
machine # [    9.623521] mass[696]:                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
machine # [    9.624931] mass[696]:   File "/nix/store/yv2wywvmyrs5xx3lk54p999g1j3w1iyi-python3.12-zeroconf-0.145.1/lib/python3.12/site-packages/zeroconf/_utils/net.py", line 412, in create_sockets
machine # [    9.626808] mass[696]:     add_multicast_member(cast(socket.socket, listen_socket), i)
machine # [    9.627835] mass[696]:   File "/nix/store/yv2wywvmyrs5xx3lk54p999g1j3w1iyi-python3.12-zeroconf-0.145.1/lib/python3.12/site-packages/zeroconf/_utils/net.py", line 316, in add_multicast_member
machine # [    9.629805] mass[696]:     listen_socket.setsockopt(socket.IPPROTO_IP, socket.IP_ADD_MEMBERSHIP, _value)
machine # [    9.631528] mass[696]: OSError: [Errno 19] No such device
machine # [    9.632409] mass[696]: 2025-04-11 08:51:54.682 INFO (MainThread) [aiorun] Entering shutdown phase.
machine # [    9.633933] mass[696]: 2025-04-11 08:51:54.682 INFO (MainThread) [aiorun] Executing provided shutdown_callback.
machine # [    9.635385] mass[696]: 2025-04-11 08:51:54.682 INFO (MainThread) [root] shutdown requested!
machine # [    9.636826] mass[696]: 2025-04-11 08:51:54.688 INFO (MainThread) [music_assistant] Stop called, cleaning up...
machine # [    9.638663] mass[696]: 2025-04-11 08:51:54.688 INFO (MainThread) [aiorun] Waiting for executor shutdown.
machine # [    9.640212] mass[696]: 2025-04-11 08:51:54.697 INFO (MainThread) [aiorun] Shutting down async generators
machine # [    9.641594] mass[696]: 2025-04-11 08:51:54.697 INFO (MainThread) [aiorun] Closing the loop.
machine # [    9.642758] mass[696]: 2025-04-11 08:51:54.697 INFO (MainThread) [aiorun] Leaving. Bye!
machine # [    9.644589] mass[696]: 2025-04-11 08:51:54.697 INFO (MainThread) [aiorun] Reraising unhandled exception
machine # [    9.648327] mass[696]: 2025-04-11 08:51:54.697 ERROR (MainThread) [root] Uncaught exception
machine # [    9.649716] mass[696]: Traceback (most recent call last):
machine # [    9.651227] mass[696]:   File "/nix/store/623yh2lx5y8255fhaj6i4vnanhdkmzc7-music-assistant-2.5.1/bin/.mass-wrapped", line 9, in <module>
machine # [    9.652914] mass[696]:     sys.exit(main())
machine # [    9.653536] mass[696]:              ^^^^^^
machine # [    9.654161] mass[696]:   File "/nix/store/623yh2lx5y8255fhaj6i4vnanhdkmzc7-music-assistant-2.5.1/lib/python3.12/site-packages/music_assistant/__main__.py", line 220, in main
machine # [    9.657149] mass[696]:     run(
machine # [    9.657673] mass[696]:   File "/nix/store/5qhn8garnkwprrv80hql9l59amqikfxf-python3.12-aiorun-2025.1.1/lib/python3.12/site-packages/aiorun/__init__.py", line 374, in run
machine # [    9.659601] mass[696]:     raise pending_exception_to_raise
machine # [    9.660407] mass[696]:   File "/nix/store/5qhn8garnkwprrv80hql9l59amqikfxf-python3.12-aiorun-2025.1.1/lib/python3.12/site-packages/aiorun/__init__.py", line 276, in run
machine # [    9.662384] mass[696]:     shutdown_callback(loop)
machine # [    9.663222] mass[696]:   File "/nix/store/623yh2lx5y8255fhaj6i4vnanhdkmzc7-music-assistant-2.5.1/lib/python3.12/site-packages/music_assistant/__main__.py", line 205, in on_shutdown
machine # [    9.665276] mass[696]:     loop.run_until_complete(mass.stop())
machine # [    9.666254] mass[696]:   File "/nix/store/f2krmq3iv5nibcvn4rw7nrnrciqprdkh-python3-3.12.9/lib/python3.12/asyncio/base_events.py", line 691, in run_until_complete
machine # [    9.669224] mass[696]:     return future.result()
machine # [    9.670042] mass[696]:            ^^^^^^^^^^^^^^^
machine # [    9.670804] mass[696]:   File "/nix/store/623yh2lx5y8255fhaj6i4vnanhdkmzc7-music-assistant-2.5.1/lib/python3.12/site-packages/music_assistant/mass.py", line 205, in stop
machine # [    9.672601] mass[696]:     await self.streams.close()
machine # [    9.673283] mass[696]:           ^^^^^^^^^^^^
machine # [    9.674028] mass[696]: AttributeError: 'MusicAssistant' object has no attribute 'streams'
machine # [    9.767094] systemd[1]: music-assistant.service: Main process exited, code=exited, status=1/FAILURE
machine # [    9.769198] systemd[1]: music-assistant.service: Failed with result 'exit-code'.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@autrimpo autrimpo requested a review from mweinelt April 11, 2025 09:00
@github-actions github-actions Bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Apr 11, 2025
@autrimpo autrimpo marked this pull request as ready for review April 11, 2025 10:29
@github-actions github-actions Bot removed the 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. label Apr 11, 2025
mweinelt
mweinelt requested changes Apr 11, 2025
View reviewed changes
Comment thread nixos/modules/services/audio/music-assistant.nix Outdated
Copy link
Copy Markdown
Member

@mweinelt mweinelt Apr 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wants/after network-online.target instead please

Copy link
Copy Markdown
Contributor Author

@autrimpo autrimpo Apr 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@autrimpo autrimpo force-pushed the music-assistant-2.5.1 branch from 02e9dbe to df816b0 Compare April 12, 2025 09:30
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label May 17, 2025
@wegank
Copy link
Copy Markdown
Member

wegank commented Jun 18, 2025

Closed by #405770.

@wegank wegank closed this Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mweinelt mweinelt mweinelt requested changes

Assignees

No one assigned

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@autrimpo @wegank @mweinelt