Skip to content

fix: include start/end time when validating availability window #716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adeiji wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

fix: include start/end time when validating availability window #716

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f301a30
fix: include start/end time when validating availability window
adeiji Apr 7, 2026
c3b8fcf
fix: Removed console.log statements
adeiji Apr 7, 2026
4fcf1aa
fix: syntax refinement and added tests
adeiji Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 25 additions & 2 deletions src/abstract/lib/GroupBuilder/GroupUtility.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,13 +238,36 @@ export class GroupUtility {

public isInsideValidDatesInterval(event: ScheduleEvent) {
const { startDate, endDate } = event.availability;
const { timeFrom, timeTo } = event.availability;
Comment thread
adeiji marked this conversation as resolved.
Outdated

const now = this.getNow();

// Time must be added to start date and end date if they are defined, otherwise the interval will be invalid.
const from =
startDate && timeFrom
? new Date(
startDate.getFullYear(),
startDate.getMonth(),
startDate.getDate(),
timeFrom.hours,
timeFrom.minutes,
)
: (startDate ?? undefined);
const to =
endDate && timeTo
? new Date(
endDate.getFullYear(),
endDate.getMonth(),
endDate.getDate(),
timeTo.hours,
timeTo.minutes,
)
: (endDate ?? undefined);

return this.isInInterval(
{
from: startDate ?? undefined,
to: endDate ?? undefined,
from,
to,
},
now,
'both',
Expand Down
Loading